Giter Site home page Giter Site logo

Comments (3)

ivirshup avatar ivirshup commented on June 18, 2024 1

I'm still dubious of the value, especially when we provide different ways of ways of optimizing the score.

What would you think of instead having sc.metrics.modularity where you match a clustering and a graph returning a modularity score?

It would basically wrap:

(
    igraph.Graph.Weighted_Adjacency(adata.obsp["connectivities"])
    .modularity(adata.obs["louvain"].cat.codes)
)

But you could also generate modularity scores for other labelings.

from scanpy.

AlSzmigiel avatar AlSzmigiel commented on June 18, 2024

What about comparing communities between for example CPM and RBERVertexPartition at the same resolution, using modularity score? This way we are not comparing scores obtained by optimization functions, just simple "external" measure.

from scanpy.

ivirshup avatar ivirshup commented on June 18, 2024

Yeah, that's why I like having it be manually computed rather than relying on the output of the clustering. This way we can make sure similar scores are used.

For API, I'm thinking:

@singledispatch
def modularity(graph: sparse.spmatrix, labels: pd.Series | np.ndarray) -> float:
    ...

@modularity.register
def _modularity_adata(adata: AnnData, labels: pd.Series | str, obsp: str) -> float:
    return modularity(
        adata.obsp[obsp],
        adata.obs[labels] if isinstance(labels, str) else labels,
    )

from scanpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.