Giter Site home page Giter Site logo

Comments (3)

Fish-Git avatar Fish-Git commented on September 23, 2024

This may be too niche to justify any enhancement efforts,

Not at all! What you propose seems quite reasonable to me. IMO it's actually a bona fide bug that should be fixed. An error on any given device definition should not prevent further processing of subsequent device definitions. The bug you describe is no different than doing:

0100.cckd
0101.cckd
(0102.cckd is missing)
0103.cckd
0104.cckd
0105.cckd
0106.cckd

and Hercules failing to define devices 0103-0106 simply because 0102 encountered an error. I think you'll agree that that would be wrong. The same can therefore be said of Hercules's handling of 0100.7 3390 $(CCUU).cckd: the simple act of the definition for device 0102 failing should not cause Hercules to not define devices 0103-0107. The situation is no different IMO.

Suffice to say the bug has now been identified and fixed by commit b7fd573.

If you're interested in testing it (I already have myself, but you might want to confirm it for yourself), checkout the 'develop' branch and build that.

Thanks for reporting it, @littlejackal! You did a good job.  :)

from hyperion.

Fish-Git avatar Fish-Git commented on September 23, 2024

p.s. Your "fail=soft" idea is IMO overkill. It's not needed. As explained in my previous comment above, the behavior you described is actually incorrect behavior (i.e. a bona fide bug), so no new option is necessary.

from hyperion.

littlejackal avatar littlejackal commented on September 23, 2024

Excellent, thank you for the feedback! The softfail option was only suggested because I wasn't sure if there was a legitimate reason for the "bug" behaviour that I just wasn't seeing, so I'm happy to go without.

Thanks for remediating; I'll definitely be giving this a test! Much appreciated.

from hyperion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.