Comments (5)
same for apple ...
Making all in .
CC cckdcdsk.o
In file included from ../cckdcdsk.c:14:
In file included from ../hercules.h:80:
../w32util.h:277:41: error: unknown type name 'OSVERSIONINFOEX'
W32_DLL_IMPORT void w32_GetWinVersInfo( OSVERSIONINFOEX* pOSVersInfoEx );
^
1 error generated.
gmake[2]: *** [Makefile:2614: cckdcdsk.o] Error 1
gmake[1]: *** [Makefile:2678: all-recursive] Error 1
gmake: *** [Makefile:1999: all] Error 2
in hercules.h the
#include "w32util.h" /* win32 porting functions */
at line 80 is unconditional
( to test I just commented it and everything works on apple sonoma )
also the coding is pretty sloppy ( pretty is the PC forform of f***ing )
in hercules.h there is the include of "w32util.h"
in w32util.h thre is the include of hercules.h
the same for too many other headers
from hyperion.
Sorry about that. w32util.h
has apparently been broken for many years. (Since 2005 from the looks of it, believe it or not!) The #endif
for _MSVC_
is in the wrong place. It should be at the very end, just before the #endif
for _W32UTIL_H
. It hasn't caused any problems until now since the DisableInvalidParameterHandling
and EnableInvalidParameterHandling
function declarations are void
functions that don't take any parameters, so non-Windows builds didn't care. My having added the new w32_GetWinVersInfo
function declaration however, finally tripped the bug.
It's now been fixed by commit ff6cc5d. Please update your Herc (git pull) and retry your build. It should work now. Tested on Kubuntu 21.10 and CentOS 6.10.
Closing.
from hyperion.
also the coding is pretty sloppy ( pretty is the PC forform of f***ing )
"pretty is the PC forform of f***ing"? :)
I've never heard that before!
What's it supposed to mean?
in hercules.h there is the include of "w32util.h"
in w32util.h thre is the include of hercules.h
the same for too many other headers
Yes, technically the #include
for w32util.h
in the hercules.h
header should be guarded with a #ifdef _MSVC_
, but as long as the w32util.h
header itself is guarded, it shouldn't make any difference. But #including it in hercules.h without any guard (and having the guard in w32util.h itself instead) is simpler/cleaner IMO.
As far as some headers re-including headers that were already included by some previously included header is concerned, my only response is: "So what?". Any header and/or source module should be free to include whatever other headers it might need regardless of whether or not they've already been #included somewhere else in the compilation unit, since ALL headers should be self-guarded against being included multiple times. So if a header is included somewhere when it was already included elsewhere, no harm should result. That's pretty much standard software programming IMHO.
from hyperion.
also the coding is pretty sloppy ( pretty is the PC forform of f***ing )
"pretty is the PC forform of f***ing"?
:)
I've never heard that before!
What's it supposed to mean?
I think that means "pretty sloppy" is being used to be politically correct and polite and not type "fucking sloppy" in a GitHub comment, like we might do. :)
from hyperion.
I think that means "pretty sloppy" is being used to be politically correct and polite and not type "fucking sloppy" in a GitHub comment, like we might do.
:)
(Doh!) Thanks Bill. I completely missed that.
from hyperion.
Related Issues (20)
- Hercules sf- command issues HOT 19
- using the macro BUILD_APPLE_M1 set by configure prevents a universal build HOT 17
- async 'sf' cmd can trip lock bug in dasd caching causing CRASH
- runnig z/osmf IZUSVR1 procedure failed in z/OS 2.5 HOT 1
- 10 seconds intermittent delay with multiple paths to a DASD device HOT 5
- Problem if ENGINES lists fewer than MAXCPU engines HOT 1
- Visual Studio 17.9.0 generating warning C4789 HOT 1
- Missing support for clang builds under Windows MSVC HOT 32
- gmake check fails HOT 3
- Confusing response to 'stop' command HOT 9
- CCKDDIAG needs to provide support for shadow files HOT 1
- GIT: Additional gitignore files? HOT 1
- FORCE parameter on 'sf' command does not work correctly HOT 14
- Compiler warnings when building with gcc version 11.4.0 - a minor issue HOT 11
- some dasd tests pollute the repository with the shadow files HOT 3
- question about the __SSE2__ intrinsics ( x86intrin.h ) HOT 6
- CTCE links fail using TSAF under VM HOT 37
- Hercules just ends without completing processing config file on Windows 11 HOT 44
- standalone physical restore issue HOT 27
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hyperion.