feat: improve keyword recognition by making color unique

[sdras]

feat: improve keyword recognition by making color unique

[alexsasharegan]

The dark theme refs were just a common reference to compare some things and come up with ideas. It's really cool to hear why you've taken a different approach on those other points. I totally respect that.

[sdras]

OK! This should be fixed now, please upgrade to the latest version. I did a few refinements as well, especially for things like case/switch/break, and ruby. Please feel free to reopen if anything looks weird.

[sdras]

Thanks for reporting this! I definitely see what you mean about the keyword, and I will work on that for the next release. For the other side notes, there are very intentional reasons why I have highlighted and contrasted certain colors sparingly. Eventually things become rainbow noise and I've worked very hard to keep the contrasts to a minimum but meaningful, especially in colorblind testing. Some things are the colors that they are in different references depending on what's surrounding them. I don't think it's productive to compare/contrast with other themes, because there are many parts of decisions that lead up a whole. If you're happier with the dark theme, that sounds like a better fit for you.

[alexsasharegan]

I’ll update and check it out today! I'm sure it's all worked out. Thanks for this!

[alexsasharegan]

I see that some keywords have changed, but are the object keys supposed to still be the purple color?

[alexsasharegan]

I think I've found the scope to play with this for JS.

{
  "name": "JS Object Keys",
  "scope": [
    "source.js meta.objectliteral.js meta.object.member.js meta.object-literal.key.js"
  ],
  "settings": {
    "foreground": "#cdebf7",
    "fontStyle": "italic"
  }
}