Comments (2)
Some more context on this: https://ask.clojure.org/index.php/11027/should-tools-build-functions-respect-with-from-tools-alpha
TL;DR: tools.build
uses a *project-root*
dynamic var and when it calls down into t.d.a to calculate a basis, it uses with-dir
to pass that context on, so using with-dir
in build.clj
is... questionable practice. However, that means that depstar
's t.b.a-compatible functions jar
and uber
are not entire compatible since they don't resolve paths via that *project-root*
and that still leaves the problem that non-tools.build
code that invokes depstar
programmatically could use with-dir
and mess with depstar
's handling of paths.
Probably the "right" solution here is for depstar
to also have a "project root" concept and to ensure everything is correctly resolved based on that and then for it to use with-dir
to bind that context when calling into t.d.a to calculate a basis and for the t.b.a-compatible API to bind depstar
's project root to t.b.a's *project-root*
... Potentially a lot of work (for a project that I really want to retire once tools.build
has its uber
task sorted out!).
from depstar.
Since this pretty much only affected me and I have a workaround, I'm closing this out.
from depstar.
Related Issues (20)
- Unable to override :mvn/local-repo
- depstar `2.1.297` doesn't seem to pick up jar-name from aliases: HOT 10
- Sunset depstar in favor of tools.build HOT 1
- clean up tmp files? HOT 3
- Split depstar into multiple -X tasks HOT 6
- Add note about "Skipping paths" warning
- Add some variant of :version-ns to add a namespace with a version var HOT 1
- Align with tools.build (future) HOT 1
- java.lang.NullPointerException HOT 1
- Update t.d.a -- use create-basis
- Add tools/usage
- 2.1.250
- Generate new pom.xml from template (like clj-new) HOT 3
- Explain JAR vs uberjar
- Aliases do not affect pom.xml sync'ing
- Bad link to tools build
- Preprocess options should not calculate basis
- Strip out tools.logging/slf4j and use println instead
- `:extra-paths` not used unless I specify `:aliases` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from depstar.