Giter Site home page Giter Site logo

Comments (6)

seanpmaxwell avatar seanpmaxwell commented on August 14, 2024 1

published changes in @sweko 's pull request to npm so closing this issue. Thanks @sweko for all your hard work!

from overnight.

seanpmaxwell avatar seanpmaxwell commented on August 14, 2024

Sorry I haven't tended to this. Is there any chance you could create a pull request for this? I've been so busy with some other stuff lately. The only middleware I've ever used is RequestHandler so that's all I'm familiar with.

from overnight.

sweko avatar sweko commented on August 14, 2024

I can take this up, as I have it functional (via an inline hack inside node_modules).
However, since error middleware (in contrast to regular middleware) has to be registered after the routes have been registered, I think it would be best to create two additional decorators (ErrorMiddleware and ClassErrorMiddleware) to handle that, and avoid mixing up the two concepts. Is that ok?

from overnight.

seanpmaxwell avatar seanpmaxwell commented on August 14, 2024

Yeah that's fine, go for it. If it's not too much extra work, mind updating the README too. That would be helpful.

from overnight.

sweko avatar sweko commented on August 14, 2024

Have it working, I'm updating the samples now

from overnight.

seanpmaxwell avatar seanpmaxwell commented on August 14, 2024

@sweko could you create a pull request with your changes

from overnight.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.