Giter Site home page Giter Site logo

Comments (3)

cxgreat2014 avatar cxgreat2014 commented on May 19, 2024

Fix method:

sea-schema/src/sqlite/discovery.rs:23:

    pub async fn discover(&self, ignore_tables: Vec<String>) -> DiscoveryResult<Schema> {
        let get_tables = SelectStatement::new()
            .column(Alias::new("name"))
            .from(SqliteMaster)
            .and_where(Expr::col(Alias::new("type")).eq("table"))
            .and_where(Expr::col(Alias::new("name")).ne("sqlite_sequence"))
            .and_where(Expr::col(Alias::new("name")).is_not_in(ignore_tables))
            .to_owned();

sea-orm-cli/src/commands/generate.rs:78

            let ignore_tables_clone = ignore_tables.clone();
            let filter_skip_tables = |table: &String| -> bool { !ignore_tables_clone.contains(table) };

sea-orm-cli/src/commands/generate.rs:139

let schema = schema_discovery.discover(ignore_tables).await?;

from sea-orm.

tyt2y3 avatar tyt2y3 commented on May 19, 2024

Thank you for your report. Seems like you have a proposed fix. Can you open a PR?

from sea-orm.

cxgreat2014 avatar cxgreat2014 commented on May 19, 2024

My fixes are superficial and not fully tested, and in the case of non-sqlite database branches there is no compatibility processing. The current code logic changes will significantly lower the current code quality. I hope that some sea-orm members can understand the problem more quickly and know a dirty hack fix based on the information I provided above. Then make a good design and submit clean fix code and test files to solve this problem,(which means a lot of work and takes a lot of time and I can't do it at present), so I hope there are more kind people like you to do this PR

from sea-orm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.