sea-orm-cli

[tyt2y3]

sea-orm-cli

[tyt2y3]

For the DATABASE_SCHEMA option, it should be entirely optional (it's useless in MySQL and optional in Postgres).
The default schema for Postgres is actually public
https://www.postgresql.org/docs/current/ddl-schemas.html

I would also suggest using DATABASE_URL and --database-url command line option for the sake of aligning with SQLx cli
https://crates.io/crates/sqlx-cli

[tyt2y3]

Yes it is the intended behavior. Too bad for the confusion. I definitely think that SeaSchema MySQL should rename that parameter to database.
As per the Postgres discovery, we actually need both database and schema

[tyt2y3]

Rename the schema to database? For sea-schema::mysql

Yes please

[billy1624]

Ok, errors will be shown so if we cannot find / read from .env

[tyt2y3]

sea-orm-cli$ cargo run
    Finished dev [unoptimized + debuginfo] target(s) in 0.33s                               
     Running `/mnt/c/Users/tyt2y/projects/sea-orm/target/debug/sea-orm-cli`                 
thread 'main' panicked at 'internal error: entered unreachable code: You should never see this message', sea-orm-cli/src/main.rs:18:14                                                  
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace     

We should display a welcome messge

[billy1624]

Will redirect to -h when no subcommand is provided.

See 47bb5b3

sea-orm/sea-orm-cli on  master is 📦 v0.1.0 via 𝗥 v1.53.0 via 🅒 base
➜ cargo r
   Compiling sea-orm-cli v0.1.0 (/Applications/MAMP/htdocs/sea-orm/sea-orm-cli)
    Finished dev [unoptimized + debuginfo] target(s) in 4.61s
     Running `/Applications/MAMP/htdocs/sea-orm/target/debug/sea-orm-cli`
sea-orm 0.1.0

USAGE:
    sea-orm-cli <SUBCOMMAND>

FLAGS:
    -h, --help       Prints help information
    -V, --version    Prints version information

SUBCOMMANDS:
    generate    Codegen related commands
    help        Prints this message or the help of the given subcommand(s)

[tyt2y3]

DATABASE_SCHEMA should be optional

[billy1624]

Regarding setting DATABASE_SCHEMA to optional. If I understand it correctly, the "schema" in sea-schema is actually the database in mysql connection string.

So, if DATABASE_SCHEMA is not provided, I will use anything after the last slash as the value for DATABASE_SCHEMA.

e.g. connection string mysql://sea:sea@localhost/bakery with DATABASE_SCHEMA: bakery.

• sea-orm/sea-orm-cli/src/main.rs

  Line 32 in 8c1b2c8

  let schema_discovery = SchemaDiscovery::new(connection, schema);

• https://github.com/SeaQL/sea-schema/blob/a235e4d4da0ca626c0c38026abb331afcc399c35/src/mysql/discovery/mod.rs#L24-L33
• https://github.com/SeaQL/sea-schema/blob/a235e4d4da0ca626c0c38026abb331afcc399c35/src/mysql/query/table.rs#L53-L81

[billy1624]

Is this behavior reasonable for MySQL?

So, if DATABASE_SCHEMA is not provided, I will use anything after the last slash as the value for DATABASE_SCHEMA.

e.g. connection string mysql://sea:sea@localhost/bakery with DATABASE_SCHEMA: bakery.

[tyt2y3]

MySQL does not have a concept of schema. So it's irrelevant.
We should in anycase extract the database from connection string

[billy1624]

We should in anycase extract the database from connection string

Yes, will do so loll

[billy1624]

Rename the schema to database? For sea-schema::mysql

[tyt2y3]

To clarify, our expected behavior:

• for MySQL --database-schema is ignored
• for Postgres --database-schema is optional, defaults to 'public'

Please make the changes to sea-orm-cli and update the docs

[billy1624]

The new ignore hidden table behavior for sea-orm-cli generate entity:

• ignore table name starts with "_" (an underscore)
• add an option --include-hidden-tables to disable this behavior