Comments (3)
Additionally, the DOMNodeComparator::nodeToText
has a bool parameter $canonicalize
suggesting it could be optional. But the only caller, DOMNodeComparator::assertEquals
, hardcodes it to true
in both cases.
I guess we really need to refactor this one :)
from comparator.
Maybe we can use some of PR #88 while doing so.
from comparator.
from comparator.
Related Issues (20)
- Compare arrays of strings ignoring line endings
- Regression in 3.0.4 and 4.0.7 HOT 3
- ArrayComparator::assertEquals declaration not compatible with Comparator::assertEquals HOT 4
- Float comparison in 4.0.8 HOT 1
- Honor $canonicalize parameter in `DOMNodeComparator::assertEquals`
- Refactor tests for `MockObjectComparator` to not use internal implementation details of PHPUnit
- comparing array with bool: true value doesn't throw a ComparisonException
- XML encoding is lost on canonicalization HOT 4
- Modernize build automation
- ArrayComparator#assertEquals(), canonicalizing stops it from comparing array keys HOT 2
- Fix issues identified by Psalm that are currently ignored (baseline) HOT 1
- Canonicalizing array comparator leaks notices HOT 1
- Warning with PHP 7.4
- Comporator for Strings
- Version 4.0.1 breaks backward compatibility HOT 3
- DOMNodeComparator fails if Node has no Document HOT 2
- DOMNodeComparator::nodeToText used C14N but don't do anything when it fail. HOT 7
- PHP 8.0 Support HOT 2
- DateTimeComparator is invalid HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from comparator.