Giter Site home page Giter Site logo

Comments (6)

cdleonard avatar cdleonard commented on June 13, 2024

@oborichkin

from scapy.

cdleonard avatar cdleonard commented on June 13, 2024

After some further digging it seems that when using consecutive PacketField those Packet sub-classes should implement a custom "extract_padding" function to determine their own length.

Made a PR for this. The test includes an adapted version of the earlier test which demonstrated the bug - it now demonstrates correct build+parse of a RTCP container SR and multiple RR

from scapy.

oborichkin avatar oborichkin commented on June 13, 2024

@cdleonard see #3580
This issue is fixed by adding extract_padding to SenderInfo:

    def extract_padding(self, p):
        return "", p

I honestly don't remember why I kept MR in Draft, maybe fixing conflicts will be enough for most cases.

from scapy.

oborichkin avatar oborichkin commented on June 13, 2024

On a second thought I remember that it was something to do with conditional fields and count_from/count_of. I'm not very happy with how they are ended up

from scapy.

cdleonard avatar cdleonard commented on June 13, 2024

My PR is just for this specific issue and it seems obviously correct.

Maybe it should be merged and then you can rebase any additional improvements on top?

from scapy.

oborichkin avatar oborichkin commented on June 13, 2024

seems reasonable

from scapy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.