Comments (6)
from scapy.
After some further digging it seems that when using consecutive PacketField those Packet sub-classes should implement a custom "extract_padding" function to determine their own length.
Made a PR for this. The test includes an adapted version of the earlier test which demonstrated the bug - it now demonstrates correct build+parse of a RTCP container SR and multiple RR
from scapy.
@cdleonard see #3580
This issue is fixed by adding extract_padding
to SenderInfo
:
def extract_padding(self, p):
return "", p
I honestly don't remember why I kept MR in Draft, maybe fixing conflicts will be enough for most cases.
from scapy.
On a second thought I remember that it was something to do with conditional fields and count_from/count_of. I'm not very happy with how they are ended up
from scapy.
My PR is just for this specific issue and it seems obviously correct.
Maybe it should be merged and then you can rebase any additional improvements on top?
from scapy.
seems reasonable
from scapy.
Related Issues (20)
- IPv6 source address selection regression HOT 4
- OSError: [Errno 9] Bad file Descriptor HOT 3
- pdfdump crashes with UnicodeEncodeError HOT 7
- Issue with packet handling for ICMPv6 packets utilizing the IPv6ExtHdrHopByHop layer. HOT 1
- Unhandled Exception after join in AsyncSniffer caused by usage of a non-existent interface
- Send/Receive Problem with ICMPv6 reply packets with IPv6ExtHdrDestOpt HOT 3
- list object has no attribute display
- Sniffign in Monitor Mode on Windows Throws Exception - libpcap & WLanHelper path issue
- send(generator) skips first packet HOT 1
- smbclientserver test timing out in autopkgtest HOT 7
- TCPSession rebuild http session bug HOT 2
- sndrcv does not return control to user after KeyboardInterrupt HOT 3
- RFE: support for the DHCP "option overload" option
- Enhancement: Validate one-line comments HOT 1
- As of NetBSD 10.0, it is possible to send packets via bpf through loopback devices HOT 1
- ICMPv6 Time Exceeded is not using `length` field
- haslayer with conditional packet fields HOT 1
- Add stop_filter parameter to SndRcvHandler
- decrypted IPv6 packet using decrypt_esp for NAT-Traversal is return wrong packet
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scapy.