line length decision

[jku]

line length decision

[L77H]

Most of the lines exceeding 80 chars limit are input data strings like public keys, it could make the code more cluttered when breaking those over multiple lines to fall within 88 chars.

[lukpueh]

Okay thanks, that's still better than fixing the 125 non-test lines to fit 80. Let's do it.

[L77H]

I would be in support of adopting the ruff default line length of 88 chars. This would reduce the number of errors from 125 to just 8 (ignoring tests) which is a quick manual fix and gives more leeway in the code style for future development.

For tests we can just ignore those with inline error suppression.

[joshuagl]

Any reason we wouldn't fix tests too if we switch the ruff default 88char?

[joshuagl]

Thanks. The 88char default for non-test files seems like a sound approach.

[L77H]

If we agree on changing the line length to 88 chars, i'll make the changes and create a new PR so we can close this issue.

[lukpueh]

Thanks. The 88char default for non-test files seems like a sound approach.

Agreed. I don't have a strong opinion about 80 vs. 88, but I'm very much pro sane defaults and minimal diffs.

Regarding minimal diff, I'm curious, will the switch also unwrap many lines because there is more space now?

[L77H]

On first sight there are around 39 unwraps across 14 files when going from 80 to 88, excluding test files.