ytsearch is returning no results found for every query

[sedmelluq]

ytsearch is returning no results found for every query

[sedmelluq]

Closed as the relevant PR was merged.

[ducc]

Disabling cookie persistence for youtube searching fixes this. Tested method (using reflection):

class DabYoutubeAudioSourceManager extends YoutubeAudioSourceManager {
  DabYoutubeAudioSourceManager() {
    super(true);

    try {
      // getting the httpInterfaceManager variable
      Field field = this.getClass().getSuperclass().getDeclaredField("httpInterfaceManager");
      field.setAccessible(true);

      // removing the final modifier
      Field modifiersField = Field.class.getDeclaredField("modifiers");
      modifiersField.setAccessible(true);
      modifiersField.setInt(field, field.getModifiers() & ~Modifier.FINAL);

      // creating a new HttpClientBuilder with cookie management disabled
      HttpClientBuilder httpClientBuilder = HttpClientTools.createSharedCookiesHttpBuilder()
              .disableCookieManagement();

      // creating a new HttpInterfaceManager with our HttpClientBuilder
      HttpInterfaceManager httpInterfaceManager = new ThreadLocalHttpInterfaceManager(httpClientBuilder,
              HttpClientTools.DEFAULT_REQUEST_CONFIG);

      // setting the new value of the field
      field.set(this, httpInterfaceManager);
    } catch (NoSuchFieldException | IllegalAccessException e) {
      e.printStackTrace();
    }
  }
}

[Shredder121]

Just to cover my bits when people say "there is no such (static) method in YoutubeAudioSourceManager"

YoutubeAudioSourceManager youtube = new YoutubeAudioSourceManager(true);
youtube.configureRequests(config ->
        RequestConfig.copy(config)
                .setCookieSpec(CookieSpecs.IGNORE_COOKIES)
                .build()
);

[Shredder121]

Crosspost from Discord, since this seems to be the issue.
It's not a cookie problem, but it seems the DOM layout changed.

So, finally had the issue of not being able to search locally.
Peppered some breakpoints, and it seems the durationElement is null.
So, hmmm, there is another video-time related class in the DOM.
There's video-time-overlay that seems to have the right content we need for the time computation.