Not working for HL-L2360DW (VERSIONCHECK=2)

[sedrubal]

Not working for HL-L2360DW (VERSIONCHECK=2)

[dlenski]

there don't seem to be any recent changes that would affect its ability to find the firmware for this printer… unless it needs some crazy hack akin to 565ef03 😅

Should've tested it first. Yes, indeed, the misspelling-based "fixes" from 565ef03 / #19 do indeed resolve this, and allow me to update the firmware successfully. 😵

[dlenski]

For what it's worth, I'm using an old version of the tool, 332eb4f, because I'm on an old version of Python, but there don't seem to be any recent changes that would affect its ability to find the firmware for this printer… unless it needs some crazy hack akin to 565ef03 😅

[dlenski]

Yes, indeed, the misspelling-based "fixes" from 565ef03 / #19 do indeed resolve this, and allow me to update the firmware successfully. 😵

Perhaps apply_mfc_l3750cdw_hack deserves a more generic name now 😭

[sedrubal]

Thanks for your report and for digging into it. I'll rename the function 😉 Is there a reason why you're stuck to an old version of Python? I think the minimum Python version is quite an arbitrary decision and we can support older versions again if required.

[dlenski]

Is there a reason why you're stuck to an old version of Python?

Running an older Linux distribution (Ubuntu 20.04) and generally being a fan of the traditional Debian-based distros’ approach to packaging Python ("only install one copy of anything").

I think the minimum Python version is quite an arbitrary decision and we can support older versions again if required.

Cool! Adding some CI to verify that the code builds and runs with older versions would be a good way to get fast feedback on things that've broken older versions.

You can see how I do things in some of my Python projects with Github-CI, like https://github.com/dlenski/python-vipaccess/blob/master/.github/workflows/test_and_release.yml#L14