Giter Site home page Giter Site logo

Comments (6)

seflless avatar seflless commented on May 22, 2024

Thanks for the good repro steps. I was able to recreate. I think I have it fixed. Try out the latest release: [email protected].

from diagrams.

jerluc avatar jerluc commented on May 22, 2024

Beautiful! So glad I can finally use this!

from diagrams.

jerluc avatar jerluc commented on May 22, 2024

@francoislaberge for my own curiosity, what was the underlying issue?

from diagrams.

seflless avatar seflless commented on May 22, 2024

To be honest, I never quite figured it out. I've had this weird issue in the past too, where the main.js you start an electron skill with gets the path to electron instead of the module for electron when you do const electron = require('electron'). In this case, the first thing to fail was:

const app = require('electron').app;

// app is undefined as require('electron') === path to the electron app, thus a string
app.on('blah', ()=>{
}); 

I upgraded from 0.37.0 of electron to 1.3.0 and the issue went away after much debugging and trying to figure it out.

from diagrams.

seflless avatar seflless commented on May 22, 2024

Did you verify that it works for you?

from diagrams.

jerluc avatar jerluc commented on May 22, 2024

Yes @francoislaberge it works as intended!

from diagrams.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.