Giter Site home page Giter Site logo

review about ebs-backup HOT 4 CLOSED

yields avatar yields commented on June 9, 2024
review

from ebs-backup.

Comments (4)

yields avatar yields commented on June 9, 2024

please :)

from ebs-backup.

achille-roussel avatar achille-roussel commented on June 9, 2024

Nice stuff 👍

=> https://github.com/segmentio/ebs-backup/blob/master/main.go#L58
It may be nice to have a graceful handling of signals here, not sure if the operations can be canceled, or at least show a warning on the first SIGINT telling the user that it may leave the system in an unpredictable state if it stops the program.

from ebs-backup.

achille-roussel avatar achille-roussel commented on June 9, 2024

Also, make this repo public ;)

from ebs-backup.

yields avatar yields commented on June 9, 2024

thanks for the quick response!

It may be nice to have a graceful handling of signals here, not sure if the operations can be canceled, or at least show a warning on the first SIGINT telling the user that it may leave the system in an unpredictable state if it stops the program.

good call, will do

Also, make this repo public ;)

want to use it and add tests first :)

from ebs-backup.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.