Giter Site home page Giter Site logo

Comments (4)

lsf37 avatar lsf37 commented on July 20, 2024

If we want to avoid that, we need to encode something like the PR number in the concurrency statement here.

This might be as simple as

concurrency: camkes-hw-pr-${{ github.event.number }}-${{ strategy.job-index }}

from camkes-vm-examples.

lsf37 avatar lsf37 commented on July 20, 2024

(We'd need to check that the event number stays the same when new commits are pushed to the PR)

from camkes-vm-examples.

axel-h avatar axel-h commented on July 20, 2024

We could also remove the concurrency field. In the kernel Hw run it also does not exist. If the machine queue serialized things that would do. Just for multiple pushed to a PR, having never pushe killing the runs of older one might be useful - or in some cases not as one might want the older runs to finish to see some intermediate results.

from camkes-vm-examples.

lsf37 avatar lsf37 commented on July 20, 2024

We could also remove the concurrency field. In the kernel Hw run it also does not exist. If the machine queue serialized things that would do.

The idea is to reduce load on the machine queue. It would still run all the old jobs that are not interesting any more and block the boards for other things during that time. If at all, I would want to add this to the kernel HW run as well when it works properly.

Just for multiple pushed to a PR, having never pushe killing the runs of older one might be useful - or in some cases not as one might want the older runs to finish to see some intermediate results.

For that case (where we do want intermediate results) I think we should then wait with the push instead of pushing multiple times and always processing everything. For some boards there is only one in the machine queue, and multiple PRs can easily amount to > 100 jobs (20-ish per run), which means most of them will just be waiting on lock for a very long time and progress will be slow for most of them.

from camkes-vm-examples.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.