Giter Site home page Giter Site logo

Comments (2)

gr2m avatar gr2m commented on June 16, 2024

This might be a regression introduced in #829 @fgreinacher

We wrap this value into a method that removes a trailing / from the string:
https://github.com/semantic-release/github/pull/829/files#diff-3c41bd6e7d07732417abb44146ae10fa613e5d61d5df96d088e44cb8d5dc557fR29

But isn't GITHUB_API_URL set by GitHub itself in GitHub Actions? Or are you setting the variable in your own environment?

from github.

fgreinacher avatar fgreinacher commented on June 16, 2024

This might be a regression introduced in #829 @fgreinacher

Indeed this happens because gitHubApiUrl (unlike gitHubUrl) is not passed through parseUrl which seems to also remove trailing slashes. I think we should add this to bring back previous behavior. If you agree I'll be happy to send a PR.

from github.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.