Package version update changes code styling

[semantic-release]

Package version update changes code styling

[gr2m]

Hi @byCedric, thanks for the kind words!

Just so I understand correctly, this issue is about the update of the package.json file in this line?

https://github.com/semantic-release/npm/blob/master/lib/update-package-version.js#L10

I think we can fix that to keep the indentation style. E.g. we could use https://www.npmjs.com/package/json-in-place, that’s what Greenkeeper is using to update the package.json files in its pull requests. Wanna send a pull request for that? Maybe add a test that the indentation style is indeed not changed so we don’t break it by accident in future

[pvdlg]

Oh sorry I was working on that for the last hour or so and I already published a fix: #71.

I'm using detect-indent and detect-newline similarly to what npm does: https://github.com/npm/npm/blob/latest/lib/install/save.js#L54

[byCedric]

Hi Gregor, yes exactly! When writing to either the package.json, package-lock.json or shrinkwrap.json the code styling will be reset to two spaces indentation. I'll create a PR with the json-in-place package now!

[byCedric]

Haha, no worries, I was just starting. Thanks for giving a notice! NPM is also the one I looked up on how they do it 😬

[semantic-release-bot]

🎉 This issue has been resolved in version 3.3.0 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[byCedric]

Thanks guys, really appreciate the change! ❤️