Comments (9)
Yes, just need to slightly extend BitmexApiProxy.cs so that we can wrap such errors into special exception-classes so then you can catch and handle this on your consumer side
from bitmex.net.
@alex-lucid @ha07z7xe Hi both, you would like to have different exception type for these codes, wouldn't you?
from bitmex.net.
Hi @semashkinvg , actually I have propagated the StatusCode itself through BitmexApiException
so that my consuming code can handle and retry - #36 , https://github.com/HA07Z7XE/Bitmex.NET/commit/b722abcd58e8a3ae6e28d223f66f5a94a6929d39
(Sorry, I did not fix my PR because I do not have a net462 environment).
My preference would be the same approach, as then other StatusCodes can also be handled from the client should the need arise.
from bitmex.net.
@ha07z7xe ok, let me have a look how it could be approached
from bitmex.net.
@ha07z7xe have a look at the commit attached to this issue, would it be sufficient in your case?
from bitmex.net.
@semashkinvg not 100%. If possible I would like to fix my PR which has the same changes. If I fix the CI build, does my PR look ok?
There are a few related (albiet breaking) changes in there around returning rate limit data which I also require,
from bitmex.net.
@ha07z7xe wow! you PR is just amazing, I dreamed to implement it half of year ago, but didn't have time to do this. Please proceed, that's absolutely great!
from bitmex.net.
@ha07z7xe please run Integration tests with your own account (Api Key and secret) but don't commit them
from bitmex.net.
Sure. I'll get something up soon.
from bitmex.net.
Related Issues (20)
- Implement and Test WebSocket.Order HOT 2
- REST connection is opened & closed on every request HOT 3
- Support multiple accounts on REST interface HOT 5
- Randomly closes down without any exception HOT 2
- TradeSocketSubscription - Bug HOT 1
- Error creating order HOT 2
- Serialization Bug for Booleans HOT 3
- Implement and Tests WebSocket.Chat
- Implement and Tests WebSocket.announcement HOT 1
- Implement and Tests WebSocket.funding
- Implement and Tests WebSocket.Wallet
- Implement and Tests WebSocket.margin HOT 4
- BitmexApiException "Signature not valid". Mono HOT 7
- Can i trade with symbols: XBTZ18 or XBTН19 HOT 5
- Custom coding
- Orderbook notifications are sent in different threads HOT 1
- Asks should be Bids in MainWindowViewModel subscribing to OrderBook10 HOT 1
- TradeSubscription events unordered
- WebSocket object not receiving welcome message HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bitmex.net.