Giter Site home page Giter Site logo

Comments (9)

radiant-alex avatar radiant-alex commented on September 17, 2024 2

Yes, just need to slightly extend BitmexApiProxy.cs so that we can wrap such errors into special exception-classes so then you can catch and handle this on your consumer side

from bitmex.net.

semashkinvg avatar semashkinvg commented on September 17, 2024

@alex-lucid @ha07z7xe Hi both, you would like to have different exception type for these codes, wouldn't you?

from bitmex.net.

ha07z7xe avatar ha07z7xe commented on September 17, 2024

Hi @semashkinvg , actually I have propagated the StatusCode itself through BitmexApiException so that my consuming code can handle and retry - #36 , https://github.com/HA07Z7XE/Bitmex.NET/commit/b722abcd58e8a3ae6e28d223f66f5a94a6929d39
(Sorry, I did not fix my PR because I do not have a net462 environment).

My preference would be the same approach, as then other StatusCodes can also be handled from the client should the need arise.

from bitmex.net.

semashkinvg avatar semashkinvg commented on September 17, 2024

@ha07z7xe ok, let me have a look how it could be approached

from bitmex.net.

semashkinvg avatar semashkinvg commented on September 17, 2024

@ha07z7xe have a look at the commit attached to this issue, would it be sufficient in your case?

from bitmex.net.

ha07z7xe avatar ha07z7xe commented on September 17, 2024

@semashkinvg not 100%. If possible I would like to fix my PR which has the same changes. If I fix the CI build, does my PR look ok?

There are a few related (albiet breaking) changes in there around returning rate limit data which I also require,

from bitmex.net.

semashkinvg avatar semashkinvg commented on September 17, 2024

@ha07z7xe wow! you PR is just amazing, I dreamed to implement it half of year ago, but didn't have time to do this. Please proceed, that's absolutely great!

from bitmex.net.

semashkinvg avatar semashkinvg commented on September 17, 2024

@ha07z7xe please run Integration tests with your own account (Api Key and secret) but don't commit them

from bitmex.net.

ha07z7xe avatar ha07z7xe commented on September 17, 2024

Sure. I'll get something up soon.

from bitmex.net.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.