semgrep 1.59.0 build failure

[chenrui333]

semgrep 1.59.0 build failure

[ihji]

Probably because the change was only released 5 days ago in https://github.com/tree-sitter/tree-sitter/releases/tag/v0.20.9

[p-linnane]

Probably worth an issue in their repo asking why that change was made, and that it's causing downstream breakage.

we might also consider creating a variant formula for [email protected]

We only create versioned formula when there is still upstream support for them. For example, we have [email protected] since it's an LTS release, while openssl@3 is the latest 3.x.x release. tree-sitter would not qualify in this case. Hopefully upstream will respond in a favorable way.

[ihji]

I'll take a look. I'm not sure if there's a simple fix for this, but if not, we might also consider creating a variant formula for [email protected] (it makes sense since there's a backward incompatible interface change between 0.20.9 and 0.20.8) and explicitly depend on it as a temporary workaround.

[emjin]

Thanks for investigating! One thing I'm uncertain about---the Makefile for tree-sitter has been that way for 3 months. They actually specifically changed it to only install api.h. Semgrep has been building tree-sitter successfully on brew in that period of time. Is there anything that changed on the homebrew end that would make installing parser.h necessary?

[aryx]

I've commented on the tree-sitter repo

[aryx]

cc @mjambon who knows the best why we use tree-sitter.h instead of api.h

[ihji]

tree-sitter/tree-sitter@60779cc seems relevant too. We might bump up the tree-sitter version at https://github.com/semgrep/ocaml-tree-sitter-core/blob/main/scripts/download-tree-sitter#L12 and recompile all language submodules to update the parser.h include directives in the generated parser.c.

[amaanq]

I'll just chime in and say that parser.h is not meant to be consumed by users - it's simply needed for a grammar's parser and scanner files for some type definitions and macros which are linked in from libtree-sitter's parser.c.