Giter Site home page Giter Site logo

Comments (4)

phs avatar phs commented on August 13, 2024

For reference, the line you are talking about appears to be here.

My opinions of the code aside, it is trying to support two separate call styles. One can either specify everything with explicitly named options, or one can do so with positional parameters. Mixing them seems to be getting us in trouble.

I suggest you restrict your usage to the named option style. In particular, something like

client.allLinks(
  :url => uri,
  :urlcols => [:title, :url, :page_authority, :domain_authority],
  :linkcols => :all,
  :filters => :external,
  :scope => :page_to_domain,
  :limit => 3
)

from linkscape-gem.

davidhq avatar davidhq commented on August 13, 2024

Thank you! The confusing thing for me was that in the documentation it says:

client.allLinks(uri, :page, :urlcols => [:title, :url, :page_authority, :domain_authority], :linkcols => :all, :filters => :external, :limit => 3)

And it doesn't include scope, it's just mentioned below... then I wanted to add that simply by scope => :page_to_domain but it returned that exception. Quite confusing ... It also doesn't say anywhere that there are two possibilities of passing parameters.

from linkscape-gem.

phs avatar phs commented on August 13, 2024

That's a bug in our documentation, thank you. I'll see that it get cleaned up.

from linkscape-gem.

davidhq avatar davidhq commented on August 13, 2024

great!

from linkscape-gem.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.