Giter Site home page Giter Site logo

Comments (5)

seratch avatar seratch commented on May 29, 2024 1

Hi @iwamot, thank you for the excellent proposal! The addition of function calling is certainly something I've been looking forward to. I haven't gone through your local branch in detail yet, but at first glance, there seem to be several changes that might not be essential. When you submit a pull request, keeping the changes minimal would be very helpful. Thanks in advance!

from chatgpt-in-slack.

iwamot avatar iwamot commented on May 29, 2024

Hi @seratch, thank you for your prompt and positive response. I am glad to hear that you were looking forward to the addition of Function Calling.

I agree wholeheartedly with your point that changes should be kept to a minimum, and I will try to reduce the diffs. Of course, if you or any other contributors could give me ideas for improvements, that would be very appreciated. It would be my pleasure to collaborate with you all on adding this feature.

Again, thank you for considering this proposal!

from chatgpt-in-slack.

iwamot avatar iwamot commented on May 29, 2024

Just a quick update: the diff has now been reduced from '306 additions and 14 deletions' to '167 additions and 16 deletions'.

from chatgpt-in-slack.

iwamot avatar iwamot commented on May 29, 2024

I think I have made reasonable improvements and will proceed to create a pull request. Thank you!
https://github.com/iwamot/ChatGPT-in-Slack/commits/function-calling-rebased

from chatgpt-in-slack.

iwamot avatar iwamot commented on May 29, 2024

Merged at #52. Thank you so much!

from chatgpt-in-slack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.