Comments (7)
@antoinejaussoin I understand the purpose of giving the proper attribution to authors asked by Giphy's team, but this module is intended to have a quick search and select tool, I don't want the user can be distracted by unuseful information. I think that the idea I proposed could fit the main need (as well the tooltip, itβs just an aesthetic issue). I can add it, maybe leaving it optional with a prop, but we have to figure out if the Giphy's dev team will like the way we will add this feature.
from react-giphy-searchbox.
I could be wrong but I think you just need a updated logo?
I don't think so @caleb15, I'm using the Poweredby_640px-White_HorizText.png
logo you can find inside the approved logos ZIP set. Anyway, with the poweredByGiphyImage
prop you can change it with the one you prefer from that set. π
from react-giphy-searchbox.
Hi again @antoinejaussoin and thanks for reporting π .
At the time I developed this module they haven't released this guidelines yet, but I think we can add what they're asking. Do you think it could be enough to add the name of the contributor for each result (linked with the original media on Ghiphy's website), or do you believe we should implement a more complex solution, like the one they are showing in their docs? I understand the needing of give the right attribution to the authors, but I don't want to add too much complexity to the UI, keeping it simple and focused in with the main purpose.
from react-giphy-searchbox.
@antoinejaussoin I quickly drafted a possible solution (take a look at the first two results in the below image), but I don't like it so much. Adding the name over the image, in our case, significantly covers the image itself. Otherwise, showing it on mouse over, forces us to manage differences between non-touch and touch devices. Any suggestions or feedback?
from react-giphy-searchbox.
A further thought: opening their website at the trending page, I can't see any attribution to authors showed over the images on mobile/touch view, neither on the onMouseOver
action. Otherwise, on desktop view I can see the attribution only on the onMouseOver
action. The problem is that our "widget", as well on desktop view, take up much less space than their desktop layout.
Anyway... following what they are doing on their website, probably a compromise solution could be to hide the attribution on mobile/touch view and show it on the onMouseOver
action on desktop view.
from react-giphy-searchbox.
Hi! Apologies for the late reply.
I was wondering if a simple tooltip over the image wouldn't be enough? As you said, it would only work on desktop but it's probably fine?
from react-giphy-searchbox.
I could be wrong but I think you just need a updated logo?
https://developers.giphy.com/faq/
What conditions does my app/project need to meet in order to get a production API Key?
Glad you asked! As per our section 5A of our Terms of Service, we require all apps that use the GIPHY API to conspicuously display "Powered By GIPHY" attribution marks where the API is utilized. You can find approved official logo marks here. You may also be asked to provide screenshots or a video of app during the application process.
https://support.giphy.com/hc/en-us/articles/360028134111-GIPHY-API-Terms-of-Service-
Approved logos: https://media.giphy.com/giphy-attribution-marks.zip
from react-giphy-searchbox.
Related Issues (20)
- README.md: project logo broken on npmjs.com
- Remove Axios.
- Production API Key HOT 2
- Feature Request - Search Text HOT 9
- Autofocus the searchbox prop HOT 3
- sped up / blurry gif? HOT 3
- Specify a hundred percent width to the component HOT 1
- Module parse failed: Unexpected character 'οΏ½' during yarn build HOT 2
- [Bug] Cannot read property 'total_count' of undefined HOT 17
- CSS Modules cannot be imported from within node_modules HOT 3
- Add typescript types
- Duplicate component keys HOT 1
- Usage in existing form component HOT 1
- How to make the component fully responsive with screen size
- Uncaught ReferenceError: module is not defined
- Don't nest search input in form HOT 2
- Update npm package with last fix
- Outdated react peer dependencies cause issues
- Package not installing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-giphy-searchbox.