Comments (2)
not 100% sure if I understand correctly 🤔
- Why do you need to "dispose" of your
CorrelationId
in theOnUnload
? would "not disposing it" allow it to still exist at the moment where SerilogWeb logs the event ? - wouldn't using or copying/adapting the current
HttpRequestIdEnricher
help ? note that it exposesstatic
accessor in case you need access to the Id of the current request
from classic.
Sorry I wasn't clear, I meant about disposing of the IDisposable property from PushProperty("CorrelationId",correlationId)
I was using.
I've taken this approach instead since it's a simple single api that returns a document based on url properties and there is no state to manage, I just abandon the session before the page ends. I will take a look at the TryGetCurrentHttpRequestId and see if that helps as well.
static Dictionary<Guid, IDisposable> logProperties = new Dictionary<Guid, IDisposable>();
protected void Session_Start(object sender, EventArgs e)
{
var guid = Guid.NewGuid();
Session["CorrelationId"] = guid;
IDisposable logProperty = Serilog.Context.LogContext.PushProperty("CorrelationId", guid);
Log.Verbose("Session {CorrelationId} started", guid);
logProperties.Add(guid, logProperty);
}
protected void Session_End(object sender, EventArgs e)
{
Guid? guid = Session["CorrelationId"] as Guid?;
if (!guid.HasValue)
{
Log.Verbose("Session with no CorrelationId ended, {CorrelationIdCount} in dictionary", logProperties.Count);
return;
}
Log.Verbose("Session {CorrelationId} ended", guid);
if (logProperties.TryGetValue(guid.Value, out var log))
{
log.Dispose();
logProperties.Remove(guid.Value);
}
}
from classic.
Related Issues (20)
- Calling cfg.LogAtLevel to set the LogEventLevel seems to disable HTTP request logging? HOT 8
- UserName enricher shows (anonymous) in ApplicationLifecycleModule with Microsoft.AspNet.WebApi.* >= 5.2.5 HOT 5
- Applicationlifecycle module question HOT 7
- Using the EnvironmentUserName if none? HOT 2
- HttpModule stops working when stressed. HOT 6
- Exception with null key in form data HOT 3
- EnableFormDataLogging not logging anything with WebApi HOT 2
- .netStandard v2 version ? HOT 1
- HttpRequestUrlEnricher gives "Request is not available in this context" exception HOT 6
- Special cases when using `FilterKeywords()` with `EnableFormDataLogging()` HOT 5
- ASP .NET Core enrichers? HOT 2
- Add Http Data To All Logging Events HOT 1
- How to troubleshoot the ApplicationLifecycleModule HttpModule is loading and configured properly? HOT 6
- WithUserName Only Working With HttpModule Logging But Doesnt Log During Web Service/API Logs HOT 8
- HttpModule isn't extensible? HOT 2
- SerilogWeb.Classic IIS classic mode incompatibility HOT 1
- Customize HttpRequestEventMessageTemplate HOT 6
- IIS Web application hang up after multiple requests stuck on "Begin request" HOT 1
- Multiple log messages for single Request with error 404 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from classic.