Comments (8)
could be caused by cloudflare
from athene2.
this is reproducible when using the ios simulator and the latest iphone
from athene2.
It looks like this was caused by webcomponents.js
, which has been solve here: 17484c9
from athene2.
CloudFlare passes window.location
object to window.URL
constructor while constructor accepts only strings, which is why https://github.com/webcomponents/webcomponentsjs/blob/c9bceeedb4077b5658d95f5755883592be92fcaf/src/URL/URL.js#L473 works very differently and causes this error, meaning redirect to another page instead of string replace.
CloudFlare already notified about this, hope they'll fix it soon.
from athene2.
Thanks for tracking this down!!
from athene2.
@nazar-pc this still doesn't make sense, just a few lines beforehand the base property is stringified and converted to a jURL instance.
from athene2.
@terinjokes, regexp works with url
variable, base
is not relevant there.
from athene2.
@nazar-pc I fixed this a while ago, but just came across this thread, I forgot what I was doing. Sorry, carry along. :)
The code that was failing on CloudFlare was a feature detection check to see if the URL constructor exists and works. It does this by passing in window.location
(and now window.location.href
) as the first parameter to the URL constructor, and checking the output.
If the URL constructor exists and works, then throughout the codebase, the URL constructor is passed two arguments, url
and base
, and I'm accustom to base
often being window.location
(now window.location.href
).
For a moment after reading this thread, I thought the issue was in this latter case, rather than the former, thus the confusion.
from athene2.
Related Issues (20)
- Zend\View\Exception\RuntimeException: Zend\View\Renderer\PhpRenderer::render: Unable to render template "layout/default/serlo-home.phtm...
- Concretize license page for quotes HOT 1
- 'multipart/mixed' used instead of 'multipart/alternative' HOT 1
- deploy script still depends on composer.phar HOT 2
- Update Serlo Startpage "Partner und Förderer" section
- editing content from an old revision of a page loads new editor
- consider server-side rendering of LaTeX to MathML HOT 1
- Add a page with all unrevised revisions HOT 1
- pls delete asset HOT 1
- Add rbock44 to the KPI Team HOT 1
- Notifications borken - Call to a member function getType() on null
- Stay within curriculum taxonomy HOT 2
- Check purge behaviour HOT 1
- New chat environment for the community HOT 1
- Review Session GarbageCollector HOT 1
- Review timezone settings HOT 4
- Silence the console HOT 6
- ReferenceError: hj is not defined
- Add static page de.serlo.org/beitrag
- Dont display newsletter popup on other tenants HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from athene2.