Giter Site home page Giter Site logo

Comments (2)

Kariel-Myrr avatar Kariel-Myrr commented on September 28, 2024

Where we should store mk.... functions?
We just importing parsers From CLI.Parser into other pkg? Or we should make some upper logic file?

from coffer.

dcastro avatar dcastro commented on September 28, 2024

Where we should store mk.... functions?

The mkQualifiedPath functions should live next to the QualifiedPath type (similar to how mkPath lives next to Path).

We just importing parsers From CLI.Parser into other pkg?

Preferably, yes.

Though we might run into some issues.
For example, right now we have:

  • the Filter type defined in CLI.Types
  • the parser parseFilter defined in CLI.Parser
  • instance FromHttpApiData Filter defined in CLI.Types

Reusing parseFilter to implement instance FromHttpApiData Filter would create a cyclic dependency between the two modules (CLI.Parser depends on CLI.Types, CLI.Types depends on CLI.Parser). To avoid this cyclic dep, we should move parseFilter to CLI.Types.

from coffer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.