Giter Site home page Giter Site logo

Comments (4)

rogerluan avatar rogerluan commented on May 29, 2024 2

What's usually done when combining textField(_:shouldChangeCharactersIn:replacementString:) (or any delegate that returns a Bool), is perform a && for all the return values :)

from textfieldcounter.

filletofish avatar filletofish commented on May 29, 2024 1

Hi @patricks,
Thank you for pointing this out.

Yes this is possible. There are two options:

  1. Expand TextFieldCounterDelegate with functions from UITextFieldDelegate and forward all delegate calls to counterDelegate.
  2. Override var delegate in such way that setting would set only private var userDelegate (or better name). Then in all delegate calls inside TextFieldCounter forward them to userDelegate.

Second option is more preferable I suppose.

Example:

private weak var userDelegate: UITextFieldDelegate?

override weak var delegate: UITextFieldDelegate? {
  set {  self.userDelegate = newValue }
  get { return self.userDelegate }
}

and forwarding:

func textFieldDidEndEditing(_ textField: UITextField) {
    // Our custom logic
    return self.delegate?. textFieldDidEndEditing(self)
}

I suppose we can forward eventextField(_:shouldChangeCharactersIn:replacementString:), this is open question.

@patricks feel free to open a PR, if you want :)

from textfieldcounter.

serralvo avatar serralvo commented on May 29, 2024 1

@patricks

I'm on it.

from textfieldcounter.

serralvo avatar serralvo commented on May 29, 2024

@patricks

Added in v1.0.2.

from textfieldcounter.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.