hpilo.IloLoginFailed with & in password

[seveas]

hpilo.IloLoginFailed with & in password

[seveas]

It is actually a bug in the ilo firmware that I think locfg.pl works around (or it has the same bug, I've not actually investigated) and locfg.pl: In XML documents, an & needs to be escaped, the XML generated by python-hpilo does this correctly. However, the iLO firmware does not properly unescape the password field.

I'm a bit hesitant to "fix" python-hpilo, so I would recommend working around this by using a password that does not contain a & character.

[Poulpatine]

I understand your point of view, you want to respect XML standards.

But as this is a bug in iLO and your code is only designed to work with iLOs (as far as I know ?), maybe would it be good to make it works ?

Regards.

[seveas]

It's not just about standards. Fixing this is going to require really nasty hacks to make sure it works on all supported python versions. Look at how the CDATA support in hpilo.py is implemented and think "three times uglier".

[seveas]

Actually, I've come up with a fairly OK way of doing this. At least it doesn't make me hide in the corner with shame. See commit 095d784, which will be in the next release.

[Poulpatine]

Thanks, it's great ! Many thanks for your reactivity.