Giter Site home page Giter Site logo

Merge steps in master about angular-200 HOT 13 CLOSED

nweldev avatar nweldev commented on June 20, 2024
Merge steps in master

from angular-200.

Comments (13)

geromegrignon avatar geromegrignon commented on June 20, 2024

i'll work on it.
Any changes requested about steps?

from angular-200.

nweldev avatar nweldev commented on June 20, 2024

Not with this issue, as we don't want to impact the slides too much for now.

from angular-200.

nweldev avatar nweldev commented on June 20, 2024

As dependencies will be updated by #95, be aware that this include to update the related Angular / rxjs / ngrx code too.

from angular-200.

geromegrignon avatar geromegrignon commented on June 20, 2024

Sure : i'll update code when i'll add steps to master branch.

from angular-200.

geromegrignon avatar geromegrignon commented on June 20, 2024

Next step:
Delete current App folder
Add a project folder with step-01 & step-01-solution child folders
Update angular.json to integrate step-01 & step-01-solution
Update ReadMe #96 starting with commands to launch server and projects

from angular-200.

geromegrignon avatar geromegrignon commented on June 20, 2024

I have the following error when trying to create projects with angular cli and following the actual naming structure for steps (aka "step-01" for example) :
image

Is it ok to rename the steps by removing the dash (so "step01" and "step01-solution" for example) ?

from angular-200.

nweldev avatar nweldev commented on June 20, 2024

You can use step1 for now, we'll think about that later.

from angular-200.

geromegrignon avatar geromegrignon commented on June 20, 2024

Fine. I'll wait you to merge #95 to make more pull requests (readme & steps).

from angular-200.

nweldev avatar nweldev commented on June 20, 2024

@geromegrignon #95 still have opened conversations you should address. As soon you have resolved them, I'll merge 😉

from angular-200.

geromegrignon avatar geromegrignon commented on June 20, 2024

The only one left (not outdate or resolved) is about project architecture.
As it's # 93 purpose and the pull request opened is about #92, it sounded legit for me to resolve it in another pull request not to be confuse about pull request content.
But if you prefer to merge this pull request clearing past root content, replacing it with a first step as a working example, i can make it too.

from angular-200.

nweldev avatar nweldev commented on June 20, 2024

@geromegrignon let me know if you need any help on this, as I'll give this school at the end of this month.

from angular-200.

geromegrignon avatar geromegrignon commented on June 20, 2024

Great i saw it on sfeir school calendar but didn't know you were in charge for that one!

I consider Importing Material Modules that way the imports array easier to read :
image

It might be harder to catch on first sight too, let me know what you think about that!

from angular-200.

nweldev avatar nweldev commented on June 20, 2024

first steps handled in #98

from angular-200.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.