Comments (2)
Thanks for the report. Ultimately what's happening is that we are attempting to push data into the write stream as it gets sent to us from the socket.io connection. Typically network connections are much slower than file I/O, so my expectation is that the write buffer doesn't usually hit its high water mark. However, it would still be beneficial to properly handle this case.
What made you find this issue? Were you having performance problems and found this via debugging, or are you reporting it as a more theoretical problem?
from socketio-file-upload.
Hi.
I had some non relevant issues while saving files on my local machine. So i checked out source code and stumbled upon code mentioned above. I played with emitChunkFailed
prop and it does really emitted error
event which meant stream highWaterMark
was hit. Same result for staging server.
I have not done any stress test for now so i cant confidently report this to be an issue.
from socketio-file-upload.
Related Issues (20)
- does it work with socket io 2.0? HOT 1
- how to move file to different folder after receiving. HOT 1
- When maxFileSize is set, emitChunkFail is force to true
- Investigate why tests require Socket.io 2.1.1
- Starting but not uploading HOT 4
- Resume upload on reconnect
- unbind listeners of server instance HOT 1
- Error when file size is greater than maxFileSize
- Rewrite in TypeScript HOT 4
- How's make a client-server-client application ? HOT 1
- Socket disconnects may cancel in-progress uploads for other clients HOT 4
- How to upload a file in base64 format? HOT 3
- How to use node js as client side. HOT 1
- Problem with nginx HOT 4
- 同学,您这个项目引入了372个开源组件,存在8个漏洞,辛苦升级一下 HOT 1
- Upload speed seems slow HOT 1
- No events from the client and the server.
- Is this supposed to work with Socket.IO version 4+? HOT 4
- How to upload files using java client?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from socketio-file-upload.