Giter Site home page Giter Site logo

Comments (4)

eXpl0it3r avatar eXpl0it3r commented on May 23, 2024

@ChrisThrasher I know you aren't a fan of the install target/don't generally use it, but it's an issue for those using it with fetch_content.
Have you ever seen any guidelines on dealing with install targets?

from sfml.

K20shores avatar K20shores commented on May 23, 2024

@eXpl0it3r I was able to exclude things from SFML

  FetchContent_Declare(sfml
      GIT_REPOSITORY https://github.com/SFML/SFML.git
      GIT_TAG        2.6.1
  )

  set(CPACK_SOURCE_IGNORE_FILES ${sfml_SOURCE_DIR})
  # FetchContent_MakeAvailable(sfml)
  if(NOT sfml_POPULATED)
    FetchContent_Populate(sfml)
    add_subdirectory(${sfml_SOURCE_DIR} ${sfml_BINARY_DIR} EXCLUDE_FROM_ALL)
  endif()

Both CPACK_SOURCE_IGNORE_FILES and EXCLUDE_FROM_ALL seem to be required

from sfml.

JonnyPtn avatar JonnyPtn commented on May 23, 2024

Yes, that's the correct fix, as proposed for the cmake template here: SFML/cmake-sfml-project#28

from sfml.

eXpl0it3r avatar eXpl0it3r commented on May 23, 2024

I'm closing this, as there's a way to work around it on the consumer end and with OpenAL gone, we have one less issue to worry about.

Feel free to add ideas if you think you know, how we can handle this better on the library side.

from sfml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.