Giter Site home page Giter Site logo

Comments (4)

heinezen avatar heinezen commented on June 10, 2024

Ah looks like clang (or the stdlib it uses) finally supports jthread now.

from openage.

TheJJ avatar TheJJ commented on June 10, 2024

Short term, you probably should patch out this error for the arch build for now, i.e. just remove the error preprocessor directive.
We added it so we can remove our custom jthread implementation once clang supports it, but I fear we have to keep it as long as we support clangs that don't have it yet...
To properly solve it, we have to remove the error too and remember deleting the custom jthread impl once we raise the minimum clang version 😎

from openage.

heinezen avatar heinezen commented on June 10, 2024

We already do the jthread C++ feature check, so if std::jthread is defined, it's always used. And it's not like our custom jthread takes a lot of space away in the code. We just have to remember to remove it when Apple finally updates their clang version in the next century ;)

from openage.

FabioLolix avatar FabioLolix commented on June 10, 2024

Builds fine thanks

from openage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.