Comments (3)
This is pretty interesting. I had not heard about this concern with CSS-In-JS before. I think this library is fine though because you can also just pass a className prop to style the root of the slider. Right? All the other elements are rendered by the user so they can all use class names on the individual elements. Or am I missing something?
from react-compound-slider.
If you use only class names, that's fine. The problem comes with inline style
attributes and style
elements, and I don't think I've seen an example that doesn't have an inline style recalculated on an event. If things can work without them, then that's cool. And if someone needs inline styles, they can relax the CSP or use some kind of nonce-based mechanism to clarify the origin of the inline style.
from react-compound-slider.
Thanks again for raising awareness on this. For RCS there's only one div in the whole library (the slider div) and it can be styled using class names or inline styles. Should not be a concern.
from react-compound-slider.
Related Issues (20)
- SVG Handle Example? HOT 1
- airbnb slider in pure js or in jquery
- Tutorial step generates TypeError: children is not a function
- Showing rail in varying color based on tick position HOT 2
- Rounding error with domain that contain decimals HOT 1
- Handle id being sorted
- Handling values and step HOT 2
- Cannot read property 'type' of null error in 3.1.0 HOT 2
- the name of Ticks is undefined HOT 2
- Change in step behavior HOT 4
- Step of 0.01 results in too many decimal places in some generated values HOT 2
- Removing the `d3-array` dependency? HOT 2
- Handle tooltips need number formatting HOT 1
- Make Range slider draggable HOT 7
- Custom mode = same min/max value? HOT 1
- Allow slider to work in popup window by registering event listener with Slider's ownerDocument
- Show track with linear gradient?
- Dragging works incorrectly on wide slider with scrolls HOT 1
- How to avoid "jumping" handles?
- GetEventData function return undefined
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-compound-slider.