Comments (3)
Hi @mfioretti,
As we've haven't had much feedback on the REST API, there are some rough edges remaining on both the API itself, as well as the provided Python client.
From the API documentation for the PUT link
endpoint:
Update an existing link with provided request data. Keep in mind that all linkβs fields will be updated.
Which is indeed not ideal as it does not allow for atomic operations on relevant fields.
Besides: "put-link --private true 2" , or e.g "put-link --title 'new title' does not work at all:
--private
sets the link visibility flag, and does not expect a boolean argument, e.g.:
shaarli put-link <parameters> 4
to update a link and set its visibility to publicshaarli put-link <parameters> --private 4
to update a link and set its visibility to private
from python-shaarli-client.
Hello @virtualtam .
I had NOT understood how the --private switch needs to be used, my bad!
As for the other issues... if every time I have to update a bookmark I have to pass to shaarli-client ALL its fields, even if only one changed, that is not ideal, but no big deal either, really. In my tests here, however, I noticed that sometimes shaarli-client did not return anything at all on STDOUT, even when it had succceeded. It should return the full json record of the updated bookmark, right? And when it returns nothing, can it be the memory issues of the php application mentioned at shaarli/Shaarli#1223, or should be worry about something else?
Thanks
from python-shaarli-client.
Which is indeed not ideal as it does not allow for atomic operations on relevant fields.
I think that would be a PATCH
request. It can be added if it's needed.
@mfioretti I'm not really familiar with this client, but if the PHP API exhausts its memory, you will find an error in the PHP/webserver logs.
from python-shaarli-client.
Related Issues (20)
- Configuration file generation HOT 2
- Better error message if the configuration isn't specified
- add media/page archiving capabilities HOT 1
- Use Pipenv for packaging/distribution/installation HOT 1
- Add support for "204 No content" return when DELETE-ing data
- sharli post-link URL dies with "expecting value" message HOT 4
- ModuleNotFoundError: No module named 'requests_jwt' HOT 2
- endpoints KeyError HOT 1
- Missing Commands after installing from pip HOT 4
- post-link with a tag HOT 4
- Add an option to bypass SSL certificate verification (self-signed certs)
- Post link with newline in the description HOT 2
- Usage in a pelican plugin HOT 1
- Support creation and update dates
- Documentation: provide a complete example HOT 1
- Traceback error ( AttributeError: 'str' object has no attribute 'decode') HOT 10
- get-links: excluding tags from results (using `-` operator) does not work HOT 2
- broken CI builds HOT 1
- adding get_link() method and get-link endpoint HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-shaarli-client.