Comments (6)
I'm running into this as well. Thanks for opening the issue!
from grpc-stubs.
Best I can do here at the moment is to revert the offending commit. I've pushed 1.24.10 to PyPi for this now. Please let me know if this "fixes" your issue, I'll leave the issue open for a bit.
from grpc-stubs.
This isn't working for me, even though in Github it looks correct.
root@30514da15ae0:/# ls /usr/local/lib/python3.10/site-packages/grpc_health-stubs/v1
__init__.pyi health.pyi health_pb2.pyi health_pb2_grpc.pyi
If I install grpc-stubs 1.24.8:
root@0526e361c909:/# ls /usr/local/lib/python3.10/site-packages/grpc_health-stubs/v1
__init__.pyi health.pyi
from grpc-stubs.
Yep - still not working for me either.
Despite it looking like health_pb2.pyi and health_pb2_grpc.pyi were deleted from 1.24.9 to 1.24.10 they are still there when I run `pip install grpc-stubs==1.24.10' and only disappear when I run 'pip install grpc-stubs==1.24.8'
Running a pip uninstall and pip install still doesn't get rid of those files - really not sure what has gone wrong here.
Those two files are still in the grpc_stubs-1.24.10.dist-info/RECORD as well:
grpc_health-stubs/v1/health_pb2.pyi,sha256=yxZ9PQu3oKjCmaCNFAFz4vkHRN014EYxBnrcPz1zPbc,2101
grpc_health-stubs/v1/health_pb2_grpc.pyi,sha256=_-N-BDkiOXBEwoE6sSQGDPyL_ECniOuvPJn9INHsPKY,1090
On the other hand - if I take either 1.24.9 or 1.24.10 and modify grpc_health-stubs/v1/health.pyi's line 39 from:
'''
def set(self, service: str, status: _health_pb2.HealthCheckResponse.ServingStatus) -> None:
'''
to
'''
def set(self, service: str, status: _health_pb2.HealthCheckResponse.ServingStatus.ValueType) -> None:
'''
Then I get no mypy errors and everything is fine - and I believe that that is the correct type for the set() function.
If you don't see any issues with this change I am happy to make a PR adding health_pb2.pyi and health_pb2_grpc.pyi back in and making that small change to health.pyi.
And I believe that will resolve this issue.
from grpc-stubs.
Please note that there are now fairly substantial new requirements for PRs to be accepted to this repo (see the README for details). If you're happy to meet those requirements when re-adding health_pb2.pyi
and health_pb2_grpc.pyi
, then by all means re-add them, but I think the minimum viable change is probably just to properly restore to 1.24.8, which it seems like I haven't quite done right by the sounds of it?
from grpc-stubs.
Fair enough - there could potentially be further issues with health_pb2.pyi or health_pb2_grpc.pyi and at this point in time I don't have sufficient time to go through them, adding test cases, etc to cover everything within those files.
And yes, it looks as though the 1.24.10 tag doesn't match what is on pypi for 1.24.10
from grpc-stubs.
Related Issues (20)
- Consider using pytest-mypy-plugins HOT 13
- Publish new version HOT 1
- Distribution doesn't include py.typed files. HOT 2
- 1.24 updates
- No stubs for `aio` HOT 9
- No stubs for client stubs? HOT 5
- can mypy be optional dependency? HOT 2
- Missing grpc StatusCode HOT 1
- The partial typing of the aio.pyi module causes an error HOT 4
- pypi version 1.53.0.1 HOT 1
- enable_server_reflection should allow aio server instances
- Typeshed HOT 9
- The object returned from `UnaryStreamMultiCallable` and `StreamStreamMultiCallable` should also be a `Future` HOT 2
- Wrong type hints for continuation in streaming interceptors HOT 1
- intercept_stream_stream in grpc.aio incorrectly marked as a coroutine HOT 2
- `ServerInterceptor.intercept_service` return type doesn't match continuation return type HOT 2
- Type hints for abstract base classes are missing `abc.ABC`
- `CallIterator` is missing `__next__` method
- Argument `grace` of Server.stop() should be Optional[float] HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grpc-stubs.