Giter Site home page Giter Site logo

Comments (14)

Mygod avatar Mygod commented on July 29, 2024
-(?i)^ss://((?<method>.+?)(?<auth>-auth)??:(?<password>.*)@(?<hostname>.+?):(?<port>\d+?))(#(?<tag>.+?))*$
+(?i)^ss://((?<method>.+?)(?<auth>-auth)?:(?<password>.*)@(?<hostname>.+):(?<port>\d+))(#(?<tag>.+))?$

Also, should #tag be included in base64_encoded_group? How about this:

(?i)^ss://(?<base64_encoded_group_1>.+)(#(?<tag>.*))?$

from shadowsocks-org.

madeye avatar madeye commented on July 29, 2024

I prefer to not appending tag after base64_encoded_group, as it would cause duplicates.

from shadowsocks-org.

Mygod avatar Mygod commented on July 29, 2024

I meant including the tag only after #.

from shadowsocks-org.

madeye avatar madeye commented on July 29, 2024

Hmm, I'm not sure. It there any good reason to do that?

from shadowsocks-org.

Mygod avatar Mygod commented on July 29, 2024

from shadowsocks-org.

madeye avatar madeye commented on July 29, 2024

Sounds good. Let's take the second proposal.

from shadowsocks-org.

Noisyfox avatar Noisyfox commented on July 29, 2024

Why don't encode tag in qr code?

from shadowsocks-org.

madeye avatar madeye commented on July 29, 2024

I'm convinced by this #25 (comment)

from shadowsocks-org.

Noisyfox avatar Noisyfox commented on July 29, 2024

I mean the qr code could contain the tag either, so that someone shares a ss url with tag via qr code and I don't need to name that server again.

from shadowsocks-org.

madeye avatar madeye commented on July 29, 2024

QR code also has the tag. It only depends on what's the URL encoded in the QR code.

from shadowsocks-org.

Noisyfox avatar Noisyfox commented on July 29, 2024

Hm, alright because the example qr code on https://shadowsocks.org/en/config/quick-guide.html doesn't contain a tag but the url right above does.

The reason I asked these question is I'm not sure if it's ok to encode remarks as tag in the qr generator which could cause some compatibility issues.

from shadowsocks-org.

wongsyrone avatar wongsyrone commented on July 29, 2024

It will be better if you clarify utf-8 encoding is needed.

ref: shadowsocks/shadowsocks-android@357130c

from shadowsocks-org.

Mygod avatar Mygod commented on July 29, 2024

from shadowsocks-org.

wongsyrone avatar wongsyrone commented on July 29, 2024

Just a suggestion, all up to you guys.

from shadowsocks-org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.