Review my new Go port

[shadowsocks]

Review my new Go port

[madeye]

Cool! I have to say Go is really the best language for network application.

[madeye]

If you'd like to move this repo to shadowsocks-org, please let me know.

[riobard]

There's still polish work to do, and I haven't tried interoperability with shadowsocks-libev yet. I'll let you know when it's ready.

Also, if we move it to the org, what to do with the old Go port which I believe @lixin9311 is working on to refactor.

[madeye]

I think you may open an issue on shadowsocks-go and discuss this with @lixin9311. It would be very nice if you can work together.

[bigtan]

@riobard As I know, many ss users use cow as shadowsocks client, could you make your golang port compatible with cow.

[riobard]

Interoperability with compliant implementations is a key goal.

[riobard]

@madeye I'm almost done. Can you try and see if my Go port works with your implementation? I don't have the environment to compile your latest libev port and I haven't found binary releases yet.

I've tested my Go port with libev port using stream ciphers and they work fine.

[madeye]

@riobard OK. Let me do the tests.

[madeye]

Stream ciphers work well. However, all the AEAD ciphers don't work.

I tried looking into https://github.com/riobard/go-shadowsocks2/blob/master/shadowaead/packet.go, and cannot figure out how it handles DataLen and DataLen.TAG. Does it follow our chunk design in SIP004?

[madeye]

OK, it's my problem. Everything works now.

[riobard]

Great! I believe the new Go port can be included in the org now as it's functionally completed and about feature-parity with the libev port.

Do I fork it into the org?

[madeye]

Two options:

1. Transfer your repo to the organization. https://help.github.com/articles/about-repository-transfers/
2. Fork your repo from organization.

Both should work.

[riobard]

I'd pick 2, otherwise I'll have to fork it back into my account (which is silly) 😂

Do I need to be granted write access to the org?

[madeye]

Not sure. I just forked it for you.

[riobard]

Thanks! :)

[simonsmh]

Would you please add config.json support?

[madeye]

I think we're done here. Please open any further issue on that repo instead.