Comments (8)
@vishwasnavadak Hi, I just finished the fix. Could you try out the latest change? next-pwa
v2.1.1 should be working as expected.
from next-pwa.
@vishwasnavadak Hi, reproduce confirmed. This is due to an update to 5.0 in workbox, they deprecated some parameters and caused this breaking change. If this is important to you, please use next-pwa
v2.0.2 for now. I will investigate if there is a good fix I can do.
from next-pwa.
I will check this. Thanks for create this issue.
from next-pwa.
@shadowwalker Sure will do. Thanks for the help
from next-pwa.
@shadowwalker That was a very quick fix. It works !!
Thank you!
from next-pwa.
@shadowwalker Same issue is arising with v2.40
Here is the error:
yarn run v1.21.1
$ next build
> [PWA] Compile client (static)
> [PWA] Auto register service worker with: <dir>\next-pwa\examples\next-9\node_modules\next-pwa\register.js
> [PWA] Service worker:<dir>\next-pwa\examples\next-9\public\sw.js
> [PWA] url: \sw.js
> [PWA] scope: \
> [PWA] Compile server
Creating an optimized production build
Failed to compile.
chunk static/runtime/main.js [initial]
static/runtime/main-e2f6bbe4483af32f35ee.js
<dir>\next-pwa\examples\next-9\node_modules\next-pwa\register.js c41b81e2b7b93250b27effc664089e9b
Unterminated string constant (4:89)
|
| if (typeof window !== 'undefined' && 'serviceWorker' in navigator) {
| window.workbox = new __WEBPACK_MODULE_REFERENCE__0_576f726b626f78__("\sw.js", { scope: "\" })
| if(true) window.workbox.register()
| }
> Build error occurred
Error: > Build failed because of webpack errors
at build (<dir>\next-pwa\examples\next-9\node_modules\next\dist\build\index.js:13:900)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
from next-pwa.
Here is the error as it is not escaping \ if no scope is defined:
window.workbox = new workbox_window__WEBPACK_IMPORTED_MODULE_0__["Workbox"]("\sw.js", { scope: "\" }) <--- Here is error
from next-pwa.
Fixed with commit
fc16e39
from next-pwa.
Related Issues (20)
- configurable Custom Worker path prefix HOT 1
- Custom Worker hash changes on every build HOT 1
- Unable to Identify Application Installation Status in iOS and Android using next-pwa HOT 2
- Error: next-pwa@npm:5.6.0 [19fba] doesn't provide @babel/core (p7b8fe), requested by babel-loader
- TS `paths` config (imports with "@-paths") does not work for imports in TS workers HOT 3
- graphql url not cached
- [PWA] Compile server - error Unexpected token in JSON at position 0
- 404 errors
- withPWA precaches on every route, but I want it to do that only on specific routes
- next pwa config override next config: Experimental ServerMinify HOT 2
- push notification error in nextjs
- Property 'workbox' does not exist on type 'Window & typeof globalThis'.ts(2339) HOT 6
- Non-stop refresh on offline mode HOT 2
- How to use next-pwa with axiom and the bundle analyzer in esm HOT 3
- worker.ts with next-pwa does not create sw.js
- Service worker gets changed every build (output not reproducible)
- Disable media download src in background
- Last release was in Dec 18, 2022, please use DuCanhGH/next-pwa HOT 4
- deprecated packages on npm install for nextjs 14.1.0 HOT 1
- ReferenceError: require is not defined in ES module scope, you can use import instead HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from next-pwa.