Comments (7)
Issue#1: note np.asarray(self.actionCount) + 1 doesn't really change self.actionCount. I add +1 to all action counts to avoid division by 0, but self.actionCount stays unchanged.
Issue#2: From my view, firstly we get the original estimation for every action, then we need to repair every action estimation per formula 2.8 in book. Then choose the action with maximum estimation.
from reinforcement-learning-an-introduction.
On Issue#1: https://docs.scipy.org/doc/numpy/reference/generated/numpy.asarray.html says 'No copy is performed if the input is already an ndarray''. I tested this on https://www.pythonanywhere.com/try-ipython/, and it actually is changing the array; therefore line 77 is actually a duplicate calc. I run print just before line 77 to see who's right.
from reinforcement-learning-an-introduction.
But self.actionCount is a list (line 40) not an ndarray
from reinforcement-learning-an-introduction.
My bad, python newbie mistake (sorry)
from reinforcement-learning-an-introduction.
No problem. And even it's ndarray, it won't be changed. Because np.asarray(self.actionCount) + 1 simply returns a new ndarray without changing the original one.
Try
a = np.zeros(4)
b = np.asarray(a) + 1
and see the value of a and b
from reinforcement-learning-an-introduction.
On Issue#2:
then line 90,
else:
# update estimation with constant step size
self.qEst[action] += 0.1 * (reward - self.qEst[action])
is duplicate because you already 'repaired every action estimation per formula' in line 62?
from reinforcement-learning-an-introduction.
No. This is normal update for action estimation. Action estimation needs to be repaired whenever we want to choose an action. But that repair isn't and shouldn't be lasting, it should be forgotten after having chosen an action.
from reinforcement-learning-an-introduction.
Related Issues (20)
- Unable to get the same results while formulating differently HOT 1
- A simpler draw function HOT 2
- nit: chapter 6 references
- something wrong in matplotlib HOT 2
- Generalization to abstract classes for Environment/Agents? HOT 2
- tictactoe compete() plays 1000 almost identical games HOT 1
- typo
- wrong figure number for chapter 11
- ten_armed_testbed.py中的figure2_3为何不用“sample_averages”
- problem about chapter04/car_rental.py HOT 1
- example to use it on human genetic data?
- Problem of excercise 2.5
- The plicy of chapter1 HOT 1
- Wrong Bellman equation for Jack's car rental problem? HOT 1
- Unclear point for the code in Blackjack example HOT 1
- l
- ch06 random_walk td method HOT 1
- chapter4 gamblers_problem, showing multiple best actions
- Chapter 2: Couldn't find the file '../images/figure_2_1.png'
- Citing this repository
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reinforcement-learning-an-introduction.