Giter Site home page Giter Site logo

Comments (8)

lars-feyerabend avatar lars-feyerabend commented on July 17, 2024

I'm sorry, I got mixed up in my attempted upgrade chaos. In dev-master, doctrine/persistence is already allowed at 2.0, but doctrine/common is still a problem:

❯ composer require shapecode/cron-bundle dev-master
./composer.json has been updated
Running composer update shapecode/cron-bundle
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires shapecode/cron-bundle dev-master -> satisfiable by shapecode/cron-bundle[dev-master].
    - shapecode/cron-bundle dev-master requires doctrine/common ^2.8 -> found doctrine/common[v2.8.0, ..., 2.13.x-dev] but the package is fixed to 3.1.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.
❯ composer why-not doctrine/common ^2.8
doctrine/orm     2.8.1       requires          doctrine/common (^3.0)
...

from cron-bundle.

lars-feyerabend avatar lars-feyerabend commented on July 17, 2024

According to its release notes, doctrine/commons breaking change with the 3.x release was removing sub-dependencies. In dev-master, you're currently using the following classes from the Doctrine\Common namespace:

  • Doctrine\Common\EventSubscriber
    (provided by doctrine/event-manager)

  • Doctrine\Common\Collections\ArrayCollection
    Doctrine\Common\Collections\Collection
    (provided by doctrine/collections)

  • Doctrine\Common\Annotations\Annotation
    Doctrine\Common\Annotations\AnnotationReader
    Doctrine\Common\Annotations\Reader
    (provided by doctrine/annotations)

  • Doctrine\Common\Persistence\Event\LifecycleEventArgs
    Doctrine\Common\Persistence\ManagerRegistry
    Doctrine\Common\Persistence\ObjectManager
    (provided by doctrine/persistence - LifecycleEventArgs seem fine, but I think the other two were missed when upgrading doctrine/persistence from ^1.2 to ^2.0, they're used in tests/Command/CronRunCommandTest.php.)

So overall I think it's fine to remove the dependency on doctrine/common and replace it with the packages above.

from cron-bundle.

nicklog avatar nicklog commented on July 17, 2024

@lars-feyerabend Hey and thank you very much. I followed your advice and removed doctrine/common with minimal changes :)

from cron-bundle.

Gemorroj avatar Gemorroj commented on July 17, 2024

@nicklog can you release 4.x brunch with fixes for symfony 5.2?

from cron-bundle.

nicklog avatar nicklog commented on July 17, 2024

Ich did a backport. Take a look at v4.0.4

from cron-bundle.

Gemorroj avatar Gemorroj commented on July 17, 2024

@nicklog need upgrade doctrine/persistence to ^1.2|^2.0 at least.

from cron-bundle.

nicklog avatar nicklog commented on July 17, 2024

@Gemorroj Only for you <3 🤪
v4.0.5 is your friend.

from cron-bundle.

Gemorroj avatar Gemorroj commented on July 17, 2024

@nicklog thank you very much. Works for me =)

from cron-bundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.