Giter Site home page Giter Site logo

Comments (7)

wcampbell0x2a avatar wcampbell0x2a commented on May 24, 2024 1

(Off-topic: I also note that you are doing benchmarking in that PR -- Good! Because I had wondered how quick deku was to parse compared to a manually written parser. It might be good to say a few words about performance somewhere in your docs/README, and if you have performance numbers, possibly show those too? The things I have been parsing haven't required bitwise granularity (I always read whole bytes), and I wonder if I'm paying for that in terms of performance?)

Currently right now, you suffer a small amount of performance due to the use of BitVec( a really small amount in the grand scheme of most program runtimes). But when all the MR's are merged we will stay the same as just writing your own ( I have some benchmarks that I haven't uploaded that will track that).

from deku.

vext01 avatar vext01 commented on May 24, 2024

I've just found the logging feature.

It somewhat helps, but it would be better if it could print the result of parsing each sub-object, instead of what will be parsed (and a bit bag of bits).

from deku.

wcampbell0x2a avatar wcampbell0x2a commented on May 24, 2024

Sorry that isn't documented, I hope to document that feature better in the future.

One thing to note is that logging is improved by this MR: #352.

I'll make sure to add the value that was decoded. I've wanted that also when debugging my decoders.

from deku.

vext01 avatar vext01 commented on May 24, 2024

Thanks so much, and thanks again for Deku. I think it's neat!

from deku.

vext01 avatar vext01 commented on May 24, 2024

(Off-topic: I also note that you are doing benchmarking in that PR -- Good! Because I had wondered how quick deku was to parse compared to a manually written parser. It might be good to say a few words about performance somewhere in your docs/README, and if you have performance numbers, possibly show those too? The things I have been parsing haven't required bitwise granularity (I always read whole bytes), and I wonder if I'm paying for that in terms of performance?)

from deku.

vext01 avatar vext01 commented on May 24, 2024

I've just tried the improved logging from #352

Much better! I hope if gets merged very soon!

from deku.

vext01 avatar vext01 commented on May 24, 2024

I also realised that logging isn't documented. I will raise a PR soonish.

from deku.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.