Comments (6)
Let me take a look at this. I think there might be a couple of things. ENABLED_PLUGINS is a bit of a misnomer. The plugin loader will grab any plugin defined in an entry point, but this setting is more about setting what plugins should be enabled by default for a channel. So if it's not in that list, it will be 'available' to be enabled via !plugins enable foo
from helga.
Some more example use from my channel - this is all uninterrupted.
palendae: !haiku
palendae: !enable poems
palendae: !haiku
palendae: !haiku add sevens She is really hard to kill
palendae: !haiku add fives Omnigul the Witch
palendae: !haiku add fives But we will prevail
palendae: !haiku
from helga.
Can you try !plugins enable poems
instead and see if that works?
from helga.
That worked.
from helga.
Cool, I think I'm going to chock this up as an enhancement. ENABLED_PLUGINS is definitely misleading, so there should be two distinct settings:
- ENABLED_PLUGINS: A list of entry_point names that would whitelist plugins that should be loaded from an entry_point and made available for use. None would imply they all are made available.
- DEFAULT_CHANNEL_PLUGINS: This would do what ENABLED_PLUGINS does now, define the plugin names that are enabled by default on a channel.
I'll probably want to make this for webhook settings as well (or at least ensure that it works the same way).
from helga.
Fixed in the 1.7.0 release. There are 3 settings:
- ENABLED_PLUGINS: serves as a plugin whitelist
- DISABLED_PLUGISN: serves as a plugin blacklist
- DEFAULT_CHANNEL_PLUGINS: serves as a list of plugins that should be 'on' by default in a channel
from helga.
Related Issues (20)
- Channel log should include extra content
- Better support of async by handling deferred HOT 1
- Auto reconnect max retries HOT 1
- ResponseNotReady ignores when first responder is false
- Re-evaluate aggressive unicode strategy
- 'helga' default nick always used even when overrides are present HOT 1
- Running console script with fresh install fails HOT 1
- Helga with custom personalities HOT 1
- Webhooks can cause plugins not to load
- Channel names truncated to a char? HOT 5
- Split out some of the bundled plugins? HOT 2
- Need version as a core plugin HOT 1
- The help plugin should allow reading from a docstring HOT 1
- XMPP client doesn't have operators HOT 1
- Add the ability to have plugin aliases HOT 2
- YouTube API has changed
- cffi version conflict HOT 1
- sasl support HOT 1
- Roadmap to helga 2.0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helga.