Giter Site home page Giter Site logo

Add Safe Support about callthis HOT 12 CLOSED

SonOfMosiah avatar SonOfMosiah commented on May 17, 2024
Add Safe Support

from callthis.

Comments (12)

shazow avatar shazow commented on May 17, 2024

Great idea, thanks for tracking. Any interest in doing a PR? :)

from callthis.

SonOfMosiah avatar SonOfMosiah commented on May 17, 2024

Absolutely. I'll try my hand at adding this in.

from callthis.

shazow avatar shazow commented on May 17, 2024

Fantastic! Let me know if you have any trouble getting going, I'd like to make callthis more contributor-friendly.

from callthis.

shazow avatar shazow commented on May 17, 2024

Added a manifest in 790fb9c, pretty sure it's working now? Didn't need to do anything special for the provider.

from callthis.

SonOfMosiah avatar SonOfMosiah commented on May 17, 2024

I think Safe also requires the app to "eager connect" or "auto connect" to the safe wallet.

from callthis.

shazow avatar shazow commented on May 17, 2024

@SonOfMosiah Does it not work for you rn? I think whatever I did for my custom wallet connecting happened to be compatible with what Safe does. 🙃

from callthis.

SonOfMosiah avatar SonOfMosiah commented on May 17, 2024

Is the latest live on callthis.link? Wasn't able to connect through app.safe.global

from callthis.

shazow avatar shazow commented on May 17, 2024

Ah you're right, it looked like it was working but it was using the wrong wallet.

I think it's actually also a CORS issue at the moment.

from callthis.

shazow avatar shazow commented on May 17, 2024

Do you have any (working) links handy for how eager/auto connect is supposed to work? Looks like everything is 404 these days. -_-

from callthis.

shazow avatar shazow commented on May 17, 2024

Ah found it via archive.org https://github.com/safe-global/safe-apps-sdk/tree/main/packages/safe-apps-provider

from callthis.

shazow avatar shazow commented on May 17, 2024

Alright that was more annoying than I hoped but should do the trick, can you confirm when you get a chance? @SonOfMosiah

from callthis.

shazow avatar shazow commented on May 17, 2024

https://app.safe.global/share/safe-app?appUrl=https%3A%2F%2Fcallthis.link&chain=eth

from callthis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.