Comments (5)
@paprikka every bug you find improves this a little bit :) Thanks for reporting. I will push a fix later today (If you could, please share a buggy file (obviously stripping out confidential information) by email (look at the commit log) or some file sharing service.
from sheetjs.
@paprikka I wonder if you are using the latest version. The version from March 21 2013 (commit hash 7ed5d70, commit message "xml preserve space regex") appeared to fix the issue. Can you send me that file?
// matches <foo>...</foo> extracts content
-function matchtag(f,g) {return new RegExp('<' + f + '>([\\s\\S]*)</' + f + '>',g||"");}
+function matchtag(f,g) {return new RegExp('<'+f+'(?: xml:space="preserve")?>([^]*)</'+f+'>',(g||"")+"m");}
from sheetjs.
@Niggler you're right, I've made some major changes to your library a month ago and haven't updated it since that time. Everything works fine now. Sorry for the confusion.
from sheetjs.
@paprikka If you've made some changes that improve parsing or fix other bugs, might I suggest submitting some of them for inclusion?
from sheetjs.
@Niggler Yes of course! I'll do that with pleasure when I come back from the holidays (in 8 days from today). I'm coming back in a week but I have to test this stuff before (that's why I didn't send any pull requests yet).
from sheetjs.
Related Issues (20)
- Gettting an Array, but of scrambled data 😰 HOT 2
- sheet_to_json from remote file not working HOT 2
- Unable to set name for worksheet separately from workbook HOT 3
- xlsx CP932 Incorrect output HOT 3
- Error appears in bower js-xlsx#~0.11.5 HOT 4
- sheet_to_json: inconsistent blank cell parsing HOT 2
- format entire column HOT 2
- reading text in shapes HOT 1
- Rearranging the XLSX.write order HOT 1
- Add VBA script to file I am creating from scratch HOT 2
- Wrong filename when download file HOT 1
- How to Define name for a range ? HOT 1
- Need to Prevent formatting of dates while reading a csv
- No option to change delimiter when writing CSV HOT 1
- Export to excel- Hyperlink doesn't work on documentation page HOT 1
- reading and writing the excel with Symbols,photos, in different tabs.
- QUOTE not defined HOT 9
- [Security] Prototype Pollution in sheetJS HOT 27
- Archive this GitHub Project HOT 3
- Thanks!
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sheetjs.