Comments (4)
So I got it working by changing the last part of utf8casecmp
from:
// If they don't match, then we return which of the original's are less
if (src1_orig_cp < src2_orig_cp) {
return -1;
} else if (src1_orig_cp > src2_orig_cp) {
return 1;
}
To:
// If they don't match, then we return the difference between the characters
return src1_cp - src2_cp;
This matches strcasecmp
's output.
from utf8.h.
I'm so sorry I missed this - all my notifications were disable in GitHub at some point and I don't know why, but I missed every single issue on every lib I have :(
Are you happy to file a PR for the above, or do you want me to file it?
from utf8.h.
You can go ahead.
from utf8.h.
utf8ncasecmp
has the same problem and can be fixed the same way.
from utf8.h.
Related Issues (20)
- Possibility of dual-licensing? HOT 5
- `utf8nvalid` reads out bounds HOT 2
- strn*/utf8n* functions HOT 5
- utf8upr/lwr size issues? HOT 3
- provide get codepoint visual width function HOT 1
- utf8ncpy incorrectly removes last valid codepoint HOT 7
- Add test similar to one used in issue 109
- support utf8 convert to utf16? HOT 1
- utf8rchr issue HOT 3
- utf8makevalid read out of bounds (+ other functions) HOT 1
- utf8makevalid : test to identify sequence length and possible values not sufficient HOT 1
- grapheme support HOT 1
- Not an issue HOT 1
- Allow programmer specified allocator HOT 2
- utf8valid with size HOT 1
- utf8tok and utf8tok_r HOT 2
- Support constexpr? HOT 3
- clang-format? HOT 1
- utf8ncat - size wraparound bug HOT 1
- Way of removing malloc completely HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from utf8.h.