Giter Site home page Giter Site logo

Comments (5)

hlayisanimazuze avatar hlayisanimazuze commented on September 26, 2024

Hi @Lukeybooi, With the current implementation, I am unable to test this item due to incomplete requirements. I cannot style the existing menu to meet the specified requirements.

from shesha-framework.

Tshepiso-R avatar Tshepiso-R commented on September 26, 2024

Hey @Lukeybooi,
It’s very difficult to use the custom style to meet the criteria. We need to focus on implementing the remaining requirements.

from shesha-framework.

Lukeybooi avatar Lukeybooi commented on September 26, 2024

Hi @Tshepiso-R I've added a color picker to change the menu item and selected menu. This should meet your criteria.

from shesha-framework.

Tshepiso-R avatar Tshepiso-R commented on September 26, 2024

@Lukeybooi

  1. There is still a need for custom styling properties for onHover and onSelect. This should be a code styling editor that allows a user to add CSS styling.
  2. The "Selected Item Background" and "Selected Item Color" properties should be renamed to "Hover Background Color" and "Hover Item Color," respectively, as these properties currently work when you hover.
  3. Add "Selected Item Background Color" and "Selected Item Color" properties.
  4. Currently, the "Selected Item Background Color" and "Selected Item Color" properties only apply to grouped menu items. This implementation should also be extended to menu items.

from shesha-framework.

Tshepiso-R avatar Tshepiso-R commented on September 26, 2024
  1. Scroll Overflow Issue:

    • When scroll overflow is selected, a line appears either above or below the menu items, depending on the browser.
    • Expected Behavior: No line should appear underneath when scroll overflow is selected by default.
    • image
  2. Scroller Enhancement:

    • The scroll icons currently have a default background color and a fixed icon color.
    • Expected Results: A transparent background is proposed, allowing the scroller to inherit the background color of the container or item, and the scroll icons to inherit the item color. The scroller must also inherit the hover styling.
    • image
  3. Inconsistent Hover Transition:

    • The hover effect on group items shows a smooth transition, but when applied to an individual group, the color changes slow and noticeable.
    • Expected Behavior: Hover color transitions should be consistent across both individual items and menu groups.
  4. Active Group Color Issue:

    • The active item color is not applied to the active group.
    • Expected Behavior: The configured active item color and background should be correctly applied to the active group.
  5. Expose Additional Properties:

    • Height
    • Font Size
    • Gap (Space between the menu items)
    • Custom Styling on Hover (Code Editor)
    • Custom Styling on Selected (Code Editor)
  6. Add Dropdown Icon for Group Menu Items:

    • Currently, you cannot differentiate between individual items and group items.
  7. Property Renaming:

    • Change the properties "Selected Item Color" and "Selected Item Background" to "Hover Item Color" and "Hover Item Background" respectively.

from shesha-framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.