Comments (4)
zhangtbj
commented on May 17, 2024
1
Agree.
em... interesting.
For the webhook or trigger functions, I think we can have more discussion about how to do it better in the future.
from build.
sbose78
commented on May 17, 2024
The reason for adding the flavour was to support git provider based webhook-related behaviour in the future.
At the moment, I don't have design in mind to implement it. I'm okay to remove it now and bring it back later on when we have a design in place which consumes this.
from build.
qu1queee
commented on May 17, 2024
@zhangtbj I think the Flavor field is not used in our logic, it seems the answer is lets keep the field for now while it might be useful in the future. If this is the case, can we close this issue?
from build.
zhangtbj
commented on May 17, 2024
Sure thing.
from build.
Related Issues (20)
- [BETA API] Update sample build strategies, builds, and buildruns
- [BETA API] Update controllers to use Beta API
- Unsupported type of credentials provided, either SSH private key or username/password is supported (exit code 110) HOT 10
- Feature Discussion: Primary Support for Multi-Arch Builds
- Git source: prevent usage of a secret with HTTP protocol
- Git source: verify usage of BitBucket
- Git source: doublecheck logging of the source URL HOT 1
- BuildRuns without BuildRef can not be canceled
- Bump go modules and CI to go v1.19
- SHP Logo not optimal with Github Dark Themes
- Add a feature/functionality to reduce the image size using dockerslim HOT 1
- GitHub Action workflow does not start when PR is created by GitHub Action HOT 1
- Following quickstart docs: Standalone BuildRun no status HOT 2
- Bump k8s version and mod dependencies
- S2I Chained builds HOT 11
- (Cluster)BuildStrategy CR about buildpacks are outdated HOT 1
- Missing custom resource definitions when installing build strategies HOT 3
- README is not match tag HOT 2
- README is not match tag
- Update Heroku sample strategies to heroku-22 stack HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from build.