Giter Site home page Giter Site logo

[Question] Change Keybind about mail HOT 8 CLOSED

shirsig avatar shirsig commented on August 19, 2024
[Question] Change Keybind

from mail.

Comments (8)

shirsig avatar shirsig commented on August 19, 2024

Until some time ago this functionality was disabled in the inbox tab which I think someone complained about and I agreed was dangerous, so I made right clicking when in the inbox tab cause switching to the send tab and also attach the item. After that change I don't think there's any notable danger anymore. Doesn't seem realistic that you accidentally right click an item while not even at the mailbox in the hope to attach it.

from mail.

fgsfdss avatar fgsfdss commented on August 19, 2024

To come back to this, when alt-tabbing out on the loading screen and back in again after loading completed, the alt input gets stuck. I attempted to mail some pots from my bank alt to my main to be met with a "you can't use that item" right clicking them, of course as the game took it as an alt-right click. If I had mailed them the other way around they would in fact have been wasted.

from mail.

shirsig avatar shirsig commented on August 19, 2024

cannot reproduce this. In any case, that would be an issue with tons of addons using unmodified clicks and or alt-clicks. To do defensive coding around people getting their keys stuck is ridiculous.

from mail.

fgsfdss avatar fgsfdss commented on August 19, 2024

Well yes, it is, however nowhere really significant as the worst that could happen is pressing a wrong keybind. Sending something like a flask over and accidentally using it would be a lot more problematic.
Might be a problem with my client. Either way, this was not a feature request to begin with, but rather a question on how to potentially edit it myself. I had a look but my lua knowledge is too limited to find and likely also to edit the event.

from mail.

shirsig avatar shirsig commented on August 19, 2024

Lazypig would give you the exact same problem. https://github.com/shirsig/Mail/blob/master/Mail.lua#L422-L426

from mail.

fgsfdss avatar fgsfdss commented on August 19, 2024

I don't use Lazypig so that's alright. If I just remove "or IsAltKeyDown()", would that cause any issues elsewhere?

from mail.

shirsig avatar shirsig commented on August 19, 2024

No, but it'll still work without alt too. It was just the first example that came to mind, there are countless addons that will fuck you to varying degrees if your keyboard doesn't work properly, after all addons can do all kinds of dangrous things like destroying items/gold, buying auctions, flag you for pvp etc.

from mail.

fgsfdss avatar fgsfdss commented on August 19, 2024

I wish I could grab the problem by its root but as it happens on my laptop as well, I assume the only option would be to find and install a different client. Not sure yet if it's worth that amount of trouble, as due to my keyboard layout I usually notice the stuck alt input quickly by moving forward with Z (it'll hide my UI instead of moving forward). I only just encountered this issue as my bank alts are stationed right next to the mailbox which does not require movement, and I used CT_Mailmod which uses alt-click until recently when I switched to Mail.
Don't worry, I've not yet insta-bought anything with Aux.
Will try this bandage-fix out for the time being either way. Thanks for the help.

from mail.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.