Comments (6)
I see. I believe the fix is simple, so I'm looking forward to your PR.
from haishinkit.swift.
@shogo4405 - It seems it might need to rename the command to deleteStream()
![image](https://private-user-images.githubusercontent.com/17129052/338955737-7e087590-dd7a-4fb5-a17a-13757b94baa9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ2OTEzNzQsIm5iZiI6MTcyNDY5MTA3NCwicGF0aCI6Ii8xNzEyOTA1Mi8zMzg5NTU3MzctN2UwODc1OTAtZGQ3YS00ZmI1LWExN2EtMTM3NTdiOTRiYWE5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI2VDE2NTExNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIyY2IwNDgxZTM3MmZkNjVlYTMzZjcyZDA3ZWY4MjVjYTY1YjczOGIzMmFmZTI3MTA1NzA0YWIyZWRkMmRjMmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.khfGU5BYx9CqlOLflwarTybhZrD3XZdsvVtvqV91yaI)
But I am not sure, if a separate method should be used to not break the API?
from haishinkit.swift.
@shogo4405 is this ok? I am waiting for a Yes or No :)
from haishinkit.swift.
No. You need to consider the behavior when viewing, the behavior when using FCPublish, and the behavior when not using FCPublish. I have no knowledge regarding deleteStream, so I don't know. It will need to be investigated.
from haishinkit.swift.
closeStream closes stream but does not unpublish (delete) stream from rtmp server. This causes the rtmp server to not send webhooks because the stream is still there in rtmp server but in closed state and it waits for timeout of rtmp ingestion. The delete stream makes sure that the stream is unpublished from rtmp server and rtmp server sends the relevant webhooks to notify the relevant services. The webhooks are important part of creating flows and this is where we are stucked using this library.
From viewing perspective, the FCUnpublish
with deleteStream
unpublishes the stream and the client player just stops loading hls fragments. If fetching stream as rtmp pull, it just stops with error that stream does not exist.
I am not sure if i am making sense.
from haishinkit.swift.
It makes sense in the context of your specific RTMP server. There are many of them, and they tend to have different implementations of RTMP spec. Therefore the best options is to create a PR with an optional deleteStream
call. Here #1393 is a good example of handing undocumented FCPublish
command in an optional manner.
from haishinkit.swift.
Related Issues (20)
- [Bug Maybe] Feedback for 1.8.0 and 1.8.2 HOT 5
- SRT no video track HOT 2
- Missing required module 'SwiftPMSupport' HOT 5
- Offscreen Rendering issue with some PNG formats HOT 3
- Undefined symbols for VisionPro HOT 3
- Low quality camera image HOT 6
- Issue with Live Streaming URL HOT 1
- Xcode15.4+, High CPU Usage and Increse Memory with SPM HOT 21
- IOStream's method append(_ sampleBuffer:) not work as expected HOT 1
- Every FLV frame has key type HOT 1
- Unable to access AVCaptureVideoPreviewLayer while using stream. HOT 1
- Failed in publishing stream to DouYin (Chinese Tiktok) with error code InvalidSign HOT 5
- When mediaServicesWereReset occurs, a crash happens with AVCaptureSession during startRunning. HOT 3
- Any ideas about optimizing with the Howling Problem? HOT 2
- High watermark memory limit exceeded when enabling the recorder on the broadcast extension.
- Phone -> OBS -> Stream quality problem HOT 3
- No audio in SRT Live Streem HOT 3
- Multiple compile time error in AMFFoundation and RTMPSharedObject Swift and SwiftUI HOT 4
- Trying to build Example project on Xcode-16.0.0-Beta with HOT 4
- SRT Connection is not streaming audio to server HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from haishinkit.swift.