Giter Site home page Giter Site logo

Packwerk can't parse `self::` about packwerk HOT 4 CLOSED

shopify avatar shopify commented on August 24, 2024
Packwerk can't parse `self::`

from packwerk.

Comments (4)

ngan avatar ngan commented on August 24, 2024 2

Yup!

from packwerk.

ngan avatar ngan commented on August 24, 2024

The example I gave was boiled down from an spec file in our code base. It looks something like this:

RSpec.shared_examples_for 'a mailer' do
  describe 'mail basics' do
    self::SOMETHING = { include: :to, exclude: :not_to }.freeze

I think we can "throw out" all self references? Since they would just resolve to whatever the containing class is and that class would declared elsewhere? So maybe the solution to this is:

  1. Add SELF = :self to here: https://github.com/Shopify/packwerk/blob/main/lib/packwerk/node.rb#L18
  2. Ignore it here: https://github.com/Shopify/packwerk/blob/main/lib/packwerk/node.rb#L40-L41
      def constant_name(constant_node)
        case type(constant_node)
        when CONSTANT_ROOT_NAMESPACE, SELF
          ""

from packwerk.

jcw- avatar jcw- commented on August 24, 2024

@ngan FYIW, I encountered this same issue, made your suggested changes, and I got past them - willing to try out a branch if you want some help QA'ing a PR... :)

from packwerk.

exterm avatar exterm commented on August 24, 2024

This should be fixed with #54, right @ngan ?

from packwerk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.