Comments (4)
Yup!
from packwerk.
The example I gave was boiled down from an spec file in our code base. It looks something like this:
RSpec.shared_examples_for 'a mailer' do
describe 'mail basics' do
self::SOMETHING = { include: :to, exclude: :not_to }.freeze
I think we can "throw out" all self
references? Since they would just resolve to whatever the containing class is and that class would declared elsewhere? So maybe the solution to this is:
- Add
SELF = :self
to here: https://github.com/Shopify/packwerk/blob/main/lib/packwerk/node.rb#L18 - Ignore it here: https://github.com/Shopify/packwerk/blob/main/lib/packwerk/node.rb#L40-L41
def constant_name(constant_node)
case type(constant_node)
when CONSTANT_ROOT_NAMESPACE, SELF
""
from packwerk.
@ngan FYIW, I encountered this same issue, made your suggested changes, and I got past them - willing to try out a branch if you want some help QA'ing a PR... :)
from packwerk.
This should be fixed with #54, right @ngan ?
from packwerk.
Related Issues (20)
- [Bug Report] deprecated_references.yml files erroneously removed if running `packwerk update-deprecations` with the `--package` argument
- [Bug Report] Behaviour of enforce_dependencies: key missing HOT 1
- [Bug Report] Improve strict mode HOT 2
- [Bug Report] Insufficient release notes HOT 2
- [Bug Report] packwerk is disabling Sorbet runtime checks, globally on Spring
- [Bug Report] Disable sorbet when using spring
- [Feature Request] Detect stale todos HOT 1
- [Bug Report] Exception when loading signatures
- [Bug Report] Default require behaviour
- [Bug Report] Dependency violation not detected when using public folders or in non-public folder with dependencies specified HOT 1
- [Feature Request] Allow configuration of `package_todo.yml` violation destinations HOT 4
- [Feature Request] Separate run-time and test-time dependencies HOT 11
- [Bug Report] HOT 2
- [Bug Report] bundler: failed to load command: packwerk HOT 1
- [Bug Report] Getting "There were stale violations found, please run `packwerk update-todo`" even there is no stale violations HOT 3
- [Bug Report] has_many relationship for serializers create false positive violations HOT 1
- [Bug] resolve module namespaces HOT 4
- [Feature Request] Haml support HOT 3
- Error: We could not extract autoload paths from your Rails app HOT 1
- [Feature Request] YARD support as method interface HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from packwerk.